Move GitHub Actions from Node 8 to Node 12 (#1164)

Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1164

Yoga CI in GitHub is currently running using Node 8, released in 2017. It has long been out of support, and is not able to install many of the packages in the updated lockfile due to version restrictions in the new packages.

Node 12 is able to install the current lockfile. Although it is old enough that security support has ended for it 5 months ago, `yoga-layout` currently fails to install on Node 12+, because a dependency, `nbind`, was reliant on V8 internals that have changed between versions, and has not published a version supporting anything later than Node 10.

There are unpublished commits in the official repo which add Node 12 support. So, we use that version when developing against the website, to jump us to something more up to date, without rewriting or removing all of the JS bindings quite yet.

Reviewed By: yungsters

Differential Revision: D40036466

fbshipit-source-id: e1b775d87854250bd74fa17ca7ba939b32aa3bd8
This commit is contained in:
Nick Gerleman
2022-10-03 18:17:23 -07:00
committed by Facebook GitHub Bot
parent 7986ca97a3
commit 80c89a48a1
3 changed files with 6 additions and 4 deletions

View File

@@ -10,7 +10,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 8.x
node-version: 12.x
- name: Install dependencies
run: yarn install --frozen-lockfile --ignore-scripts
working-directory: website