DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Modify unittest

Browse Source 
Summary:
- Disable destructor tests in Unity Editor, seems GC is flaky.
- Use current native instance counts

Reviewed By: emilsjolander

Differential Revision: D4018951

fbshipit-source-id: a57f0e1fa5a46e7de0b88235124d437d20e4082b
This commit is contained in:
Kazuki Sakamoto
2016-10-14 07:00:50 -07:00
committed by Facebook Github Bot
parent b45a7e3737
commit 832d07902e
1 changed files with 87 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

172
csharp/tests/Facebook.CSSLayout/CSSNodeTest.cs
View File

@@ -105,76 +105,23 @@ namespace Facebook.CSSLayout
public void TestDispose() public void TestDispose()
{ {
ForceGC(); ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount()); int instanceCount = CSSNode.GetInstanceCount();
CSSNode node = new CSSNode(); CSSNode node = new CSSNode();
Assert.AreEqual(1, CSSNode.GetInstanceCount()); Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
node.Dispose(); node.Dispose();
Assert.AreEqual(0, CSSNode.GetInstanceCount()); Assert.AreEqual(instanceCount, CSSNode.GetInstanceCount());
} }
[Test] [Test]
public void TestDisposeWithUsing() public void TestDisposeWithUsing()
{ {
ForceGC(); ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount()); int instanceCount = CSSNode.GetInstanceCount();
using (CSSNode node = new CSSNode()) using (CSSNode node = new CSSNode())
{ {
Assert.AreEqual(1, CSSNode.GetInstanceCount()); Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
} }
Assert.AreEqual(0, CSSNode.GetInstanceCount()); Assert.AreEqual(instanceCount, CSSNode.GetInstanceCount());
}
[Test]
public void TestDestructor()
{
ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount());
TestDestructorForGC();
ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount());
}
private void TestDestructorForGC()
{
CSSNode node = new CSSNode();
Assert.IsNotNull(node);
Assert.AreEqual(1, CSSNode.GetInstanceCount());
node = null;
}
[Test]
public void TestDestructorWithChildren()
{
ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount());
TestDestructorWithChildrenForGC1();
ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount());
}
private void TestDestructorWithChildrenForGC1()
{
CSSNode node = new CSSNode();
Assert.AreEqual(1, CSSNode.GetInstanceCount());
TestDestructorWithChildrenForGC2(node, 1);
ForceGC();
Assert.AreEqual(2, CSSNode.GetInstanceCount());
TestDestructorWithChildrenForGC2(node, 2);
ForceGC();
Assert.AreEqual(3, CSSNode.GetInstanceCount());
node = null;
}
private void TestDestructorWithChildrenForGC2(CSSNode parent, int count)
{
CSSNode child = new CSSNode();
Assert.AreEqual(count + 1, CSSNode.GetInstanceCount());
parent.Insert(0, child);
child = null;
} }
[Test] [Test]
@@ -197,38 +144,15 @@ namespace Facebook.CSSLayout
child.Free(); child.Free();
} }
[Test]
public void TestDisposeParent()
{
ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount());
CSSNode parent = new CSSNode();
Assert.AreEqual(1, CSSNode.GetInstanceCount());
TestDisposeParentForGC(parent);
ForceGC();
Assert.AreEqual(2, CSSNode.GetInstanceCount());
parent.Dispose();
ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount());
}
private void TestDisposeParentForGC(CSSNode parent)
{
CSSNode child = new CSSNode();
Assert.AreEqual(2, CSSNode.GetInstanceCount());
parent.Insert(0, child);
child = null;
}
[Test] [Test]
public void TestDisposeChild() public void TestDisposeChild()
{ {
ForceGC(); ForceGC();
Assert.AreEqual(0, CSSNode.GetInstanceCount()); int instanceCount = CSSNode.GetInstanceCount();
CSSNode parent = new CSSNode(); CSSNode parent = new CSSNode();
CSSNode child0 = new CSSNode(); CSSNode child0 = new CSSNode();
CSSNode child1 = new CSSNode(); CSSNode child1 = new CSSNode();
Assert.AreEqual(3, CSSNode.GetInstanceCount()); Assert.AreEqual(instanceCount + 3, CSSNode.GetInstanceCount());
Assert.AreEqual(0, parent.Count); Assert.AreEqual(0, parent.Count);
parent.Insert(0, child1); parent.Insert(0, child1);
Assert.AreEqual(0, parent.IndexOf(child1)); Assert.AreEqual(0, parent.IndexOf(child1));
@@ -236,7 +160,7 @@ namespace Facebook.CSSLayout
Assert.AreEqual(0, parent.IndexOf(child0)); Assert.AreEqual(0, parent.IndexOf(child0));
Assert.AreEqual(1, parent.IndexOf(child1)); Assert.AreEqual(1, parent.IndexOf(child1));
child0.Dispose(); child0.Dispose();
Assert.AreEqual(2, CSSNode.GetInstanceCount()); Assert.AreEqual(instanceCount + 2, CSSNode.GetInstanceCount());
Assert.AreEqual(1, parent.Count); Assert.AreEqual(1, parent.Count);
Assert.AreEqual(0, parent.IndexOf(child1)); Assert.AreEqual(0, parent.IndexOf(child1));
} }
@@ -259,5 +183,83 @@ namespace Facebook.CSSLayout
GC.Collect(GC.MaxGeneration); GC.Collect(GC.MaxGeneration);
GC.WaitForPendingFinalizers(); GC.WaitForPendingFinalizers();
} }
#if !UNITY_EDITOR
[Test]
public void TestDestructor()
{
ForceGC();
int instanceCount = CSSNode.GetInstanceCount();
TestDestructorForGC(instanceCount);
ForceGC();
Assert.AreEqual(instanceCount, CSSNode.GetInstanceCount());
}
private void TestDestructorForGC(int instanceCount)
{
CSSNode node = new CSSNode();
Assert.IsNotNull(node);
Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
node = null;
}
[Test]
public void TestDestructorWithChildren()
{
ForceGC();
int instanceCount = CSSNode.GetInstanceCount();
TestDestructorWithChildrenForGC1(instanceCount);
ForceGC();
Assert.AreEqual(instanceCount, CSSNode.GetInstanceCount());
}
private void TestDestructorWithChildrenForGC1(int instanceCount)
{
CSSNode node = new CSSNode();
Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
TestDestructorWithChildrenForGC2(node, instanceCount + 1);
ForceGC();
Assert.AreEqual(instanceCount + 2, CSSNode.GetInstanceCount());
TestDestructorWithChildrenForGC2(node, instanceCount + 2);
ForceGC();
Assert.AreEqual(instanceCount + 3, CSSNode.GetInstanceCount());
node = null;
}
private void TestDestructorWithChildrenForGC2(CSSNode parent, int instanceCount)
{
CSSNode child = new CSSNode();
Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
parent.Insert(0, child);
child = null;
}
[Test]
public void TestDisposeParent()
{
ForceGC();
int instanceCount = CSSNode.GetInstanceCount();
CSSNode parent = new CSSNode();
Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
TestDisposeParentForGC(parent, instanceCount + 1);
ForceGC();
Assert.AreEqual(instanceCount + 2, CSSNode.GetInstanceCount());
parent.Dispose();
ForceGC();
Assert.AreEqual(instanceCount, CSSNode.GetInstanceCount());
}
private void TestDisposeParentForGC(CSSNode parent, int instanceCount)
{
CSSNode child = new CSSNode();
Assert.AreEqual(instanceCount + 1, CSSNode.GetInstanceCount());
parent.Insert(0, child);
child = null;
}
#endif
} }
} }