DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

no need to pass env to ref method , we can directly use getCurrentEnv()

Browse Source 
Summary: We can use getCurrentEnv() instead of passing environment variable around

Reviewed By: amir-shalem

Differential Revision: D17842042

fbshipit-source-id: 185b174ae7c08e746bc76c0600c2e326b15c4993
This commit is contained in:
Sidharth Guglani
2019-10-10 05:31:30 -07:00
committed by Facebook Github Bot
parent 050893f15a
commit 869a33eb13
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/jni/YGJNIVanilla.cpp
View File

@@ -21,8 +21,7 @@ using facebook::yoga::detail::Log;
static inline ScopedLocalRef<jobject> YGNodeJobject( static inline ScopedLocalRef<jobject> YGNodeJobject(
YGNodeRef node, YGNodeRef node,
void* layoutContext) { void* layoutContext) {
return reinterpret_cast<PtrJNodeMapVanilla*>(layoutContext) return reinterpret_cast<PtrJNodeMapVanilla*>(layoutContext)->ref(node);
->ref(getCurrentEnv(), node);
} }
static inline YGNodeRef _jlong2YGNodeRef(jlong addr) { static inline YGNodeRef _jlong2YGNodeRef(jlong addr) {

3
java/jni/YGJTypesVanilla.h
View File

@@ -29,7 +29,8 @@ public:
} }
} }
ScopedLocalRef<jobject> ref(JNIEnv* env, YGNodeRef node) { ScopedLocalRef<jobject> ref(YGNodeRef node) {
JNIEnv* env = getCurrentEnv();
auto idx = ptrsToIdxs_.find(node); auto idx = ptrsToIdxs_.find(node);
if (idx == ptrsToIdxs_.end()) { if (idx == ptrsToIdxs_.end()) {
return ScopedLocalRef<jobject>(env); return ScopedLocalRef<jobject>(env);