GitHub Actions Cleanup (#1467)

Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1467

1. Avoid reusing workflow names between validation and publish jobs, since they show up with the same UI when wanting to adhoc trigger a publish.
2. Merge SwiftPM checks into Validate Apple job
3. Merge remnants of website-next workflow into website workflow (and remove a redundant explicit build step already removed in one workflow)
4. Run more validation on push to release branch
5. Do not run website validation off of main, since it is only ever deployed from main branch

Reviewed By: cipolleschi

Differential Revision: D51236885

fbshipit-source-id: dd8165aa9871f173d8914f345569c6cde1edda72
This commit is contained in:
Nick Gerleman
2023-11-13 03:57:52 -08:00
committed by Facebook GitHub Bot
parent 6f41a27e31
commit 8c1a672f92
9 changed files with 40 additions and 91 deletions

View File

@@ -1,4 +1,4 @@
name: Website name: Publish Website
on: on:
push: push:

View File

@@ -1,10 +1,11 @@
name: Android name: Validate Android
on: on:
pull_request: pull_request:
push: push:
branches: branches:
- main - main
- 'release-*'
workflow_dispatch: workflow_dispatch:
jobs: jobs:

View File

@@ -1,15 +1,16 @@
name: Apple name: Validate Apple
on: on:
pull_request: pull_request:
push: push:
branches: branches:
- main - main
- 'release-*'
workflow_dispatch: workflow_dispatch:
jobs: jobs:
lint-pods: lint-pods:
name: Lint pod name: Build [CocoaPods]
runs-on: macos-latest runs-on: macos-latest
steps: steps:
@@ -20,3 +21,16 @@ jobs:
- name: pod lib lint - name: pod lib lint
run: pod lib lint --verbose --include-podspecs=**/*.podspec run: pod lib lint --verbose --include-podspecs=**/*.podspec
test:
name: Build [SwiftPM]
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- name: Build Debug
run: swift build -c debug
- name: Build Release
run: swift build -c release

View File

@@ -1,10 +1,11 @@
name: C++ name: Validate C++
on: on:
pull_request: pull_request:
push: push:
branches: branches:
- main - main
- 'release-*'
workflow_dispatch: workflow_dispatch:
env: env:

View File

@@ -1,10 +1,11 @@
name: JavaScript name: Validate JavaScript
on: on:
pull_request: pull_request:
push: push:
branches: branches:
- main - main
- 'release-*'
workflow_dispatch: workflow_dispatch:
env: env:

View File

@@ -1,21 +0,0 @@
name: Python
on:
pull_request:
push:
branches:
- main
workflow_dispatch:
jobs:
format:
name: Format
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: black --check
uses: ./.github/actions/black
with:
directory: ${{ github.workspace }}

View File

@@ -1,22 +0,0 @@
name: Swift
on:
pull_request:
push:
branches:
- main
workflow_dispatch:
jobs:
test:
name: Build
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- name: Build Debug
run: swift build -c debug
- name: Build Release
run: swift build -c release

View File

@@ -1,37 +0,0 @@
name: Website (Next)
on:
pull_request:
push:
branches:
- main
workflow_dispatch:
build:
name: Build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup
uses: ./.github/actions/setup-js
- name: Build Website
run: yarn build
working-directory: website-next
typecheck:
name: Typecheck
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: yarn install
run: yarn install --frozen-lockfile
working-directory: javascript
- name: yarn tsc
run: yarn tsc
working-directory: website-next

View File

@@ -1,7 +1,9 @@
name: Website name: Validate Website
on: on:
pull_request: pull_request:
branches:
- main
push: push:
branches: branches:
- main - main
@@ -32,10 +34,20 @@ jobs:
- name: Setup - name: Setup
uses: ./.github/actions/setup-js uses: ./.github/actions/setup-js
- name: Build Yoga
run: yarn build
working-directory: javascript
- name: Build Website - name: Build Website
run: yarn build run: yarn build
working-directory: website-next working-directory: website-next
typecheck:
name: Typecheck [Docusaurus]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup
uses: ./.github/actions/setup-js
- name: yarn tsc
run: yarn tsc
working-directory: website-next