Fix issue where percentages were off of the border box, not padding box (#1485)
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1485 X-link: https://github.com/facebook/react-native/pull/41686 The size of the containing block is the size of the padding box of the containing node for absolute nodes. We were looking at `containingNode->getLayout().measuredDimension(Dimension::Width)` which is the border box. So we need to subtract the border from this. Added a test that was failing before this change as well Reviewed By: NickGerleman Differential Revision: D51330526 fbshipit-source-id: adc448dfb71b54f1bbed0d9d61c5553bda4b106c
This commit is contained in:
committed by
Facebook GitHub Bot
parent
f6c4a8e8e4
commit
9b87d8b3f3
@@ -93,7 +93,7 @@
|
||||
<div style="width:20%; height:20%; left:20%; top:20%; position: absolute;"></div>
|
||||
</div>
|
||||
|
||||
<div id="absolute_layout_percentage_height_based_on_padded_parent" data-disabled="true" style="flex-direction:column; width:100px; height:100px; padding-top: 10px; border-top: 10px solid black;">
|
||||
<div id="absolute_layout_percentage_height_based_on_padded_parent" style="flex-direction:column; width:100px; height:100px; padding-top: 10px; border-top: 10px solid black;">
|
||||
<div style="width:100px; height:50%; position: absolute;"></div>
|
||||
</div>
|
||||
|
||||
|
@@ -324,3 +324,13 @@
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div id="static_position_containing_block_padding_and_border">
|
||||
<div
|
||||
style="width: 400px; height: 400px; padding: 8px 1px 4px 9px; border-width: 5px 7px 4px 2px; position: relative">
|
||||
<div style="height:100px; width: 100px; position: static">
|
||||
<div style="height: 61%; width: 41%; position: absolute">
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
Reference in New Issue
Block a user