From 9e44f0f4d437c330d4ccacb51498bbb674119be0 Mon Sep 17 00:00:00 2001 From: Lukas Woehrl Date: Thu, 5 Jan 2017 22:03:17 +0100 Subject: [PATCH] code review changes --- yoga/Yoga.c | 5 +++-- yoga/Yoga.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/yoga/Yoga.c b/yoga/Yoga.c index 89a9dec5..f22b6199 100644 --- a/yoga/Yoga.c +++ b/yoga/Yoga.c @@ -1025,6 +1025,7 @@ static bool YGIsBaselineLayout(const YGNodeRef node) { return true; } } + return false; } @@ -2575,9 +2576,9 @@ static void YGNodelayoutImpl(const YGNodeRef node, break; } case YGAlignBaseline: { - child->layout.position[pos[crossAxis]] = + child->layout.position[YGEdgeTop] = currentLead + maxAscentForCurrentLine - YGBaseline(child) + - YGNodeLeadingPosition(child, crossAxis, availableInnerCrossDim); + YGNodeLeadingPosition(child, YGFlexDirectionColumn, availableInnerCrossDim); break; } case YGAlignAuto: diff --git a/yoga/Yoga.h b/yoga/Yoga.h index 1b23b54b..0413af71 100644 --- a/yoga/Yoga.h +++ b/yoga/Yoga.h @@ -50,7 +50,6 @@ typedef YGSize (*YGMeasureFunc)(YGNodeRef node, float height, YGMeasureMode heightMode); typedef float (*YGBaselineFunc)(YGNodeRef node); - typedef void (*YGPrintFunc)(YGNodeRef node); typedef int (*YGLogger)(YGLogLevel level, const char *format, va_list args);