From 9e77349e656bd0f6368aae5f9442752d2a9d5690 Mon Sep 17 00:00:00 2001 From: Dmitry Ivakhnenko Date: Mon, 12 Dec 2022 12:37:54 +0300 Subject: [PATCH] fix warning about abstract non-virtual destructor --- javascript/sources/Node.hh | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/javascript/sources/Node.hh b/javascript/sources/Node.hh index d277b1f0..225b1727 100644 --- a/javascript/sources/Node.hh +++ b/javascript/sources/Node.hh @@ -17,14 +17,17 @@ #include "./Value.hh" #include "./Config.hh" -struct MeasureCallback { +class MeasureCallback { +public: + virtual ~MeasureCallback() {} virtual Size measure(float width, int widthMode, float height, int heightMode) = 0; }; -struct MeasureCallbackWrapper : public emscripten::wrapper { +class MeasureCallbackWrapper : public emscripten::wrapper { +public: EMSCRIPTEN_WRAPPER(MeasureCallbackWrapper); Size measure(float width, int widthMode, float height, int heightMode) { @@ -32,11 +35,14 @@ struct MeasureCallbackWrapper : public emscripten::wrapper { } }; -struct DirtiedCallback { +class DirtiedCallback { +public: + virtual ~DirtiedCallback() {} virtual void dirtied() = 0; }; -struct DirtiedCallbackWrapper : public emscripten::wrapper { +class DirtiedCallbackWrapper : public emscripten::wrapper { +public: EMSCRIPTEN_WRAPPER(DirtiedCallbackWrapper); void dirtied() {