Remove YGNodeMarkDirtyAndPropagateToDescendants (#1448)

Summary:
X-link: https://github.com/facebook/react-native/pull/41305

Pull Request resolved: https://github.com/facebook/yoga/pull/1448

This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable).

Reviewed By: javache

Differential Revision: D50963933

fbshipit-source-id: 6482bd269928188b6469a358ffde5c4f9f5f9527
This commit is contained in:
Nick Gerleman
2023-11-07 21:27:59 -08:00
committed by Facebook GitHub Bot
parent 283e3203f6
commit 9eb8a62739
7 changed files with 0 additions and 33 deletions

View File

@@ -92,10 +92,6 @@ bool YGNodeIsDirty(YGNodeConstRef node) {
return resolveRef(node)->isDirty();
}
void YGNodeMarkDirtyAndPropagateToDescendants(const YGNodeRef node) {
return resolveRef(node)->markDirtyAndPropagateDownwards();
}
YGNodeRef YGNodeNewWithConfig(const YGConfigConstRef config) {
auto* node = new yoga::Node{resolveRef(config)};
yoga::assertFatal(

View File

@@ -94,12 +94,6 @@ YG_EXPORT void YGNodeCalculateLayout(
// this dirty marking manually.
YG_EXPORT void YGNodeMarkDirty(YGNodeRef node);
// Marks the current node and all its descendants as dirty.
//
// Intended to be used for Yoga benchmarks. Don't use in production, as calling
// `YGCalculateLayout` will cause the recalculation of each and every node.
YG_EXPORT void YGNodeMarkDirtyAndPropagateToDescendants(YGNodeRef node);
YG_EXPORT void YGNodePrint(YGNodeConstRef node, YGPrintOptions options);
YG_EXPORT bool YGFloatIsUndefined(float value);

View File

@@ -640,13 +640,6 @@ void Node::markDirtyAndPropagate() {
}
}
void Node::markDirtyAndPropagateDownwards() {
isDirty_ = true;
for_each(children_.begin(), children_.end(), [](Node* childNode) {
childNode->markDirtyAndPropagateDownwards();
});
}
float Node::resolveFlexGrow() const {
// Root nodes flexGrow should always be 0
if (owner_ == nullptr) {

View File

@@ -341,7 +341,6 @@ class YG_EXPORT Node : public ::YGNode {
const float mainSize,
const float crossSize,
const float ownerWidth);
void markDirtyAndPropagateDownwards();
// Other methods
YGValue getFlexStartMarginValue(FlexDirection axis) const;