DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

In-place JS environment

Browse Source 
Summary:
This change restructures the package to try to remove the JS build step from the inner loop. Instead, we have a single `src` directory that we babel transform when using, then apply the same transform inline during prepublish.

At the end, we will be publishing a source directory with Babel transformed TS, JS, and TS declarations.

We do a little spring cleaning when doing this. Fixing up some of the folder/file conventions, and removing the non-export-map fallbacks.

We cannot remove the need for a native build.

Reviewed By: yungsters

Differential Revision: D45682153

fbshipit-source-id: ea2dd75c2dd6e3529b1ef6cf6ac6a64a270049a4
This commit is contained in:
Nick Gerleman
2023-05-09 15:35:42 -07:00
committed by Facebook GitHub Bot
parent 0a6a581936
commit aa812d0e48
28 changed files with 130 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
javascript/just.config.ts
View File

@@ -10,7 +10,6 @@
import {
argv,
cleanTask,
copyTask,
eslintTask,
logger,
jestTask,
@@ -32,15 +31,6 @@ option('fix');
task('clean', cleanTask({paths: ['build', 'dist']}));
task(
'prepare-for-build',
parallel(
babelTransformTask({paths: ['src_js'], dest: 'dist'}),
copyTask({paths: ['src_js/**/*.d.ts'], dest: 'dist'}),
emcmakeGenerateTask(),
),
);
function defineFlavor(flavor: string, env: NodeJS.ProcessEnv) {
task(`cmake-build:${flavor}`, cmakeBuildTask({targets: [flavor]}));
task(
@@ -49,7 +39,7 @@ function defineFlavor(flavor: string, env: NodeJS.ProcessEnv) {
);
task(
`test:${flavor}`,
series('prepare-for-build', `cmake-build:${flavor}`, `jest:${flavor}`),
series(emcmakeGenerateTask(), `cmake-build:${flavor}`, `jest:${flavor}`),
);
}
@@ -68,12 +58,12 @@ task(
cmakeBuildTask({targets: ['asmjs-sync', 'wasm-sync']}),
);
task('build', series('prepare-for-build', 'cmake-build:all'));
task('build', series(emcmakeGenerateTask(), 'cmake-build:all'));
task(
'test',
series(
'prepare-for-build',
emcmakeGenerateTask(),
series('cmake-build:asmjs-async', 'jest:asmjs-async'),
series('cmake-build:asmjs-sync', 'jest:asmjs-sync'),
series('cmake-build:wasm-async', 'jest:wasm-async'),
@@ -83,26 +73,41 @@ task(
task(
'benchmark',
series('prepare-for-build', 'cmake-build:sync', runBenchTask()),
series(emcmakeGenerateTask(), 'cmake-build:sync', runBenchTask()),
);
task(
'lint',
parallel(
tscTask(),
tscTask({noEmit: true}),
series(eslintTask({fix: argv().fix}), clangFormatTask({fix: argv().fix})),
),
);
function babelTransformTask(opts: {
paths: ReadonlyArray<string>;
dest: string;
}) {
return () => {
const args = [...opts.paths, '--source-maps', '--out-dir', opts.dest];
logger.info(`Transforming [${opts.paths.join(',')}] to '${opts.dest}'`);
task(
'prepublish',
parallel(
'build',
tscTask({emitDeclarationOnly: true}),
babelTransformTask({dir: 'src'}),
),
);
return spawn(node, [require.resolve('@babel/cli/bin/babel'), ...args]);
function babelTransformTask(opts: {dir: string}) {
return () => {
const args = [
opts.dir,
'--source-maps',
'--out-dir',
opts.dir,
'--extensions',
'.js,.ts',
];
logger.info(`Transforming "${path.resolve(opts.dir)}"`);
return spawn(node, [require.resolve('@babel/cli/bin/babel'), ...args], {
cwd: __dirname,
});
};
}