DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove YGUnwrapFloatOptional

Browse Source 
Summary:
Replaces `YGUnwrapFloatOptional` with `YGFloatOptional::unwrap`.

This leads to more idiomatic C++, and to less function call nesting, thus increasing readability.

Reviewed By: SidharthGuglani

Differential Revision: D13439604

fbshipit-source-id: 33b43c08d725c253c359959e7cbbd83fd6bd9ba4
This commit is contained in:
David Aurelio
2018-12-13 07:09:30 -08:00
committed by Facebook Github Bot
parent 6bdd39d0ed
commit aaa018bbea
6 changed files with 211 additions and 201 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/YGFloatOptionalTest.cpp
View File

@@ -200,8 +200,8 @@ TEST(YGFloatOptionalTest, YGFloatOptionalMax) {
YGFloatOptional{1.125f});
}
TEST(YGFloatOptionalTest, YGUnwrapFloatOptional) {
ASSERT_TRUE(YGFloatIsUndefined(YGUnwrapFloatOptional(empty)));
ASSERT_EQ(YGUnwrapFloatOptional(zero), 0.0f);
ASSERT_EQ(YGUnwrapFloatOptional(YGFloatOptional{123456.78f}), 123456.78f);
TEST(YGFloatOptionalTest, unwrap) {
ASSERT_TRUE(YGFloatIsUndefined(empty.unwrap()));
ASSERT_EQ(zero.unwrap(), 0.0f);
ASSERT_EQ(YGFloatOptional{123456.78f}.unwrap(), 123456.78f);
}