DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix crash when you layout multiple absolute nodes in the same static subtree (#1686)

Browse Source 
Summary:
X-link: https://github.com/facebook/react-native/pull/45952

Pull Request resolved: https://github.com/facebook/yoga/pull/1686

https://en.wikipedia.org/wiki/Short-circuit_evaluation 🫠

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D60997231

fbshipit-source-id: 11d70086eecfb5481c578477f288138370016a83
This commit is contained in:
Joe Vilches
2024-08-08 22:41:29 -07:00
committed by Facebook GitHub Bot
parent 5009f5c1ac
commit ae8ede9b53
6 changed files with 450 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/YGRelayoutTest.cpp
View File

@@ -219,11 +219,17 @@ TEST(YogaTest, has_new_layout_flag_set_static) {
YGNodeStyleSetHeight(root_child0, 10);
YGNodeInsertChild(root, root_child0, 0);
YGNodeRef root_child0_child1 = YGNodeNew();
YGNodeStyleSetPositionType(root_child0_child1, YGPositionTypeAbsolute);
YGNodeStyleSetWidth(root_child0_child1, 5);
YGNodeStyleSetHeight(root_child0_child1, 5);
YGNodeInsertChild(root_child0, root_child0_child1, 0);
YGNodeRef root_child0_child0 = YGNodeNew();
YGNodeStyleSetPositionType(root_child0_child0, YGPositionTypeStatic);
YGNodeStyleSetWidth(root_child0_child0, 5);
YGNodeStyleSetHeight(root_child0_child0, 5);
YGNodeInsertChild(root_child0, root_child0_child0, 0);
YGNodeInsertChild(root_child0, root_child0_child0, 1);
YGNodeRef root_child0_child0_child0 = YGNodeNew();
YGNodeStyleSetPositionType(root_child0_child0_child0, YGPositionTypeAbsolute);