Use libc++ in Ubuntu Clang Build (#1440)
Summary: An ubuntu-latest image update caused build failures, where GTest importing chrono headers caused an error inside of stdlib++ when being compiled by Clang. This switches to explicitly asking for libc++ (LLVM stdlib) in the reference Ubuntu Clang build instead of stdlibc++ (GCC stdlib). We don’t force this in CMake logic, to not force a specific stdlib for users compiling Yoga alongside other libraries. E.g. https://github.com/facebookexperimental/libunifex/issues/86 Pull Request resolved: https://github.com/facebook/yoga/pull/1440 Reviewed By: joevilches Differential Revision: D50790965 Pulled By: NickGerleman fbshipit-source-id: fe525cfb4385a9a5ae6a02fcbc6decad0e07ff6e
This commit is contained in:
committed by
Facebook GitHub Bot
parent
4f98bfe40a
commit
b19a07cff9
2
.github/actions/setup-cpp/action.yml
vendored
2
.github/actions/setup-cpp/action.yml
vendored
@@ -18,6 +18,8 @@ runs:
|
||||
run: |
|
||||
echo "CC=/usr/bin/clang" >> $GITHUB_ENV
|
||||
echo "CXX=/usr/bin/clang++" >> $GITHUB_ENV
|
||||
echo "CXXFLAGS=-stdlib=libc++" >> $GITHUB_ENV
|
||||
echo "LDFLAGS=-stdlib=libc++" >> $GITHUB_ENV
|
||||
|
||||
- name: Set GCC as compiler
|
||||
if: ${{ inputs.toolchain == 'GCC' }}
|
||||
|
Reference in New Issue
Block a user