Revamp tests for row reverse + border after fix
Summary: this is fixed now so we can turn it on Reviewed By: NickGerleman Differential Revision: D50348206 fbshipit-source-id: 61c2a72164c6f0ee91b1b5b576d3f129e8cfbe40
This commit is contained in:
committed by
Facebook GitHub Bot
parent
b52d6ce7f2
commit
b558059b74
@@ -95,28 +95,28 @@ test.skip('aspect_ratio_does_not_stretch_cross_axis_dim', () => {
|
||||
|
||||
expect(root_child0_child0.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0.getComputedWidth()).toBe(300);
|
||||
expect(root_child0_child0.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0.getComputedWidth()).toBe(285);
|
||||
expect(root_child0_child0.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child0.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child0.getComputedWidth()).toBe(197);
|
||||
expect(root_child0_child0_child0.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child0.getComputedWidth()).toBe(187);
|
||||
expect(root_child0_child0_child0.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child1.getComputedLeft()).toBe(197);
|
||||
expect(root_child0_child0_child1.getComputedLeft()).toBe(187);
|
||||
expect(root_child0_child0_child1.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child1.getComputedWidth()).toBe(5);
|
||||
expect(root_child0_child0_child1.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child1.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child2.getComputedLeft()).toBe(202);
|
||||
expect(root_child0_child0_child2.getComputedLeft()).toBe(192);
|
||||
expect(root_child0_child0_child2.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2.getComputedWidth()).toBe(98);
|
||||
expect(root_child0_child0_child2.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child2.getComputedWidth()).toBe(93);
|
||||
expect(root_child0_child0_child2.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child2_child0.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0.getComputedWidth()).toBe(98);
|
||||
expect(root_child0_child0_child2_child0.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child2_child0.getComputedWidth()).toBe(93);
|
||||
expect(root_child0_child0_child2_child0.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedTop()).toBe(0);
|
||||
@@ -125,8 +125,8 @@ test.skip('aspect_ratio_does_not_stretch_cross_axis_dim', () => {
|
||||
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedWidth()).toBe(98);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedWidth()).toBe(93);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedHeight()).toBe(187);
|
||||
|
||||
root.calculateLayout(undefined, undefined, Direction.RTL);
|
||||
|
||||
@@ -140,40 +140,40 @@ test.skip('aspect_ratio_does_not_stretch_cross_axis_dim', () => {
|
||||
expect(root_child0.getComputedWidth()).toBe(300);
|
||||
expect(root_child0.getComputedHeight()).toBe(300);
|
||||
|
||||
expect(root_child0_child0.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0.getComputedLeft()).toBe(30);
|
||||
expect(root_child0_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0.getComputedWidth()).toBe(300);
|
||||
expect(root_child0_child0.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0.getComputedWidth()).toBe(285);
|
||||
expect(root_child0_child0.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child0.getComputedLeft()).toBe(103);
|
||||
expect(root_child0_child0_child0.getComputedLeft()).toBe(98);
|
||||
expect(root_child0_child0_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child0.getComputedWidth()).toBe(197);
|
||||
expect(root_child0_child0_child0.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child0.getComputedWidth()).toBe(187);
|
||||
expect(root_child0_child0_child0.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child1.getComputedLeft()).toBe(98);
|
||||
expect(root_child0_child0_child1.getComputedLeft()).toBe(93);
|
||||
expect(root_child0_child0_child1.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child1.getComputedWidth()).toBe(5);
|
||||
expect(root_child0_child0_child1.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child1.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child2.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child2.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2.getComputedWidth()).toBe(98);
|
||||
expect(root_child0_child0_child2.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child2.getComputedWidth()).toBe(93);
|
||||
expect(root_child0_child0_child2.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child2_child0.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0.getComputedWidth()).toBe(98);
|
||||
expect(root_child0_child0_child2_child0.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child2_child0.getComputedWidth()).toBe(93);
|
||||
expect(root_child0_child0_child2_child0.getComputedHeight()).toBe(187);
|
||||
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedLeft()).toBe(93);
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedLeft()).toBe(88);
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedWidth()).toBe(5);
|
||||
expect(root_child0_child0_child2_child0_child0.getComputedHeight()).toBe(0);
|
||||
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedLeft()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedTop()).toBe(0);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedWidth()).toBe(98);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedHeight()).toBe(197);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedWidth()).toBe(93);
|
||||
expect(root_child0_child0_child2_child0_child1.getComputedHeight()).toBe(187);
|
||||
} finally {
|
||||
if (typeof root !== 'undefined') {
|
||||
root.freeRecursive();
|
||||
|
@@ -1440,7 +1440,7 @@ test('flex_direction_row_reverse_border_left', () => {
|
||||
config.free();
|
||||
}
|
||||
});
|
||||
test.skip('flex_direction_row_reverse_border_start', () => {
|
||||
test('flex_direction_row_reverse_border_start', () => {
|
||||
const config = Yoga.Config.create();
|
||||
let root;
|
||||
|
||||
@@ -1590,7 +1590,7 @@ test('flex_direction_row_reverse_border_right', () => {
|
||||
config.free();
|
||||
}
|
||||
});
|
||||
test.skip('flex_direction_row_reverse_border_end', () => {
|
||||
test('flex_direction_row_reverse_border_end', () => {
|
||||
const config = Yoga.Config.create();
|
||||
let root;
|
||||
|
||||
|
Reference in New Issue
Block a user