From b57abb2f6045caed1c0f7563edde119011249a66 Mon Sep 17 00:00:00 2001 From: Kazuki Sakamoto Date: Fri, 7 Oct 2016 11:07:48 -0700 Subject: [PATCH] Remove unused GCHandle Summary: - Unused _context GCHandle prevent calling CSSNode destructor. - CSSNode C# impl will retain children node when calling CSSNodeInsertChild, so the lifetime of C# object is the same as the lifetime of native instance. Reviewed By: emilsjolander Differential Revision: D3981697 fbshipit-source-id: 71f0f7be97fd694d27934d7d07deb64ee08b2840 --- csharp/Facebook.CSSLayout/CSSNode.cs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/csharp/Facebook.CSSLayout/CSSNode.cs b/csharp/Facebook.CSSLayout/CSSNode.cs index 4b6f1849..c17b1b00 100644 --- a/csharp/Facebook.CSSLayout/CSSNode.cs +++ b/csharp/Facebook.CSSLayout/CSSNode.cs @@ -18,7 +18,6 @@ namespace Facebook.CSSLayout { private bool _isDisposed; private IntPtr _cssNode; - private IntPtr _context; private CSSNode _parent; private List _children; @@ -83,9 +82,7 @@ namespace Facebook.CSSLayout if (_cssNode != IntPtr.Zero) { Native.CSSNodeFree(_cssNode); - GCHandle.FromIntPtr(_context).Free(); _cssNode = IntPtr.Zero; - _context = IntPtr.Zero; } } @@ -97,8 +94,6 @@ namespace Facebook.CSSLayout } _cssNode = Native.CSSNodeNew(); - _context = (IntPtr)GCHandle.Alloc(this); - Native.CSSNodeSetContext(_cssNode, _context); _children = new List(4); Native.CSSNodeSetPrintFunc(_cssNode, _printFunc); } @@ -717,4 +712,4 @@ namespace Facebook.CSSLayout return ((IEnumerable)_children).GetEnumerator(); } } -} \ No newline at end of file +}