DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove comparison to YGUndefined *and* 0.0f

Browse Source 
Summary: Removes a check introduced in D6969537, comparing `totalFlexGrowFactors` and `resolveFlexGrow` to both `0.0` *and* undefined.

Reviewed By: SidharthGuglani

Differential Revision: D15431425

fbshipit-source-id: 13c8f24e1bc8c49496097a6aa78e20ee5d3964a7
This commit is contained in:
David Aurelio
2019-05-22 09:39:28 -07:00
committed by Facebook Github Bot
parent 54e863cef2
commit b74c0d4766
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
yoga/Yoga.cpp
View File

@@ -2859,11 +2859,8 @@ static void YGNodelayoutImpl(
availableInnerMainDim = maxInnerMainDim; availableInnerMainDim = maxInnerMainDim;
} else { } else {
if (!node->getConfig()->useLegacyStretchBehaviour && if (!node->getConfig()->useLegacyStretchBehaviour &&
((YGFloatIsUndefined( (collectedFlexItemsValues.totalFlexGrowFactors == 0 ||
collectedFlexItemsValues.totalFlexGrowFactors) && node->resolveFlexGrow() == 0)) {
collectedFlexItemsValues.totalFlexGrowFactors == 0) ||
(YGFloatIsUndefined(node->resolveFlexGrow()) &&
node->resolveFlexGrow() == 0))) {
// If we don't have any children to flex or we can't flex the node // If we don't have any children to flex or we can't flex the node
// itself, space we've used is all space we need. Root node also // itself, space we've used is all space we need. Root node also
// should be shrunk to minimum // should be shrunk to minimum