DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Enable Clang Tidy (#1586)

Browse Source 
Summary:
X-link: https://github.com/facebook/litho/pull/976

Pull Request resolved: https://github.com/facebook/yoga/pull/1586

X-link: https://github.com/facebook/react-native/pull/43299

Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks.

Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster.

Before:
{F1463947076}

After:
{F1463946802}

This also cleans up all the no-op shallow const parameters in headers.

{F1463943386}

Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D54461054

fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
This commit is contained in:
Nick Gerleman
2024-03-04 02:28:02 -08:00
committed by Facebook GitHub Bot
parent 47a56db5f6
commit b959c79a2a
43 changed files with 537 additions and 306 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
benchmark/TreeDeserialization.h
View File

@@ -18,35 +18,35 @@ namespace facebook::yoga {
using namespace nlohmann;
YGFlexDirection flexDirectionFromString(std::string str);
YGFlexDirection flexDirectionFromString(const std::string& str);
YGJustify justifyContentFromString(std::string str);
YGJustify justifyContentFromString(const std::string& str);
YGAlign alignFromString(std::string str);
YGAlign alignFromString(const std::string& str);
YGWrap wrapFromString(std::string str);
YGWrap wrapFromString(const std::string& str);
YGOverflow overflowFromString(std::string str);
YGOverflow overflowFromString(const std::string& str);
YGDisplay displayFromString(std::string str);
YGDisplay displayFromString(const std::string& str);
YGPositionType positionTypeFromString(std::string str);
YGPositionType positionTypeFromString(const std::string& str);
YGUnit unitFromJson(json& j);
YGEdge edgeFromString(std::string str);
YGEdge edgeFromString(const std::string& str);
YGErrata errataFromString(std::string str);
YGErrata errataFromString(const std::string& str);
YGExperimentalFeature experimentalFeatureFromString(std::string str);
YGExperimentalFeature experimentalFeatureFromString(const std::string& str);
std::string edgeStringFromPropertyName(
json::iterator it,
std::string propertyName);
const json::iterator& it,
const std::string& propertyName);
YGDirection directionFromString(std::string str);
YGDirection directionFromString(const std::string& str);
YGMeasureMode measureModeFromString(std::string str);
YGMeasureMode measureModeFromString(const std::string& str);
SerializedMeasureFunc serializedMeasureFuncFromJson(json& j);
} // namespace facebook::yoga