Enable Clang Tidy (#1586)

Summary:
X-link: https://github.com/facebook/litho/pull/976

Pull Request resolved: https://github.com/facebook/yoga/pull/1586

X-link: https://github.com/facebook/react-native/pull/43299

Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks.

Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster.

Before:
{F1463947076}

After:
{F1463946802}

This also cleans up all the no-op shallow const parameters in headers.

{F1463943386}

Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D54461054

fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f

tests/EventsTest.cpp

@@ -45,8 +45,11 @@ struct EventArgs {
 };
 
 class EventTest : public ::testing::Test {
-  ScopedEventSubscription subscription = {&EventTest::listen};
-  static void listen(YGNodeConstRef, Event::Type, Event::Data);
+  ScopedEventSubscription subscription{&EventTest::listen};
+  static void listen(
+      YGNodeConstRef /*node*/,
+      Event::Type /*type*/,
+      Event::Data /*data*/);
 
  public:
   static std::vector<EventArgs> events;

tests/SmallValueBufferTest.cpp

@@ -13,7 +13,7 @@ namespace facebook::yoga {
 constexpr size_t kBufferSize = 4;
 
 TEST(SmallValueBuffer, copy_assignment_with_overflow) {
-  std::array<uint16_t, kBufferSize + 1> handles;
+  std::array<uint16_t, kBufferSize + 1> handles{};
 
   SmallValueBuffer<kBufferSize> buffer1;
   for (size_t i = 0; i < kBufferSize + 1; ++i) {

tests/YGBaselineFuncTest.cpp

@@ -10,7 +10,7 @@
 
 static float
 _baseline(YGNodeConstRef node, const float /*width*/, const float /*height*/) {
-  float* baseline = (float*)YGNodeGetContext(node);
+  auto* baseline = (float*)YGNodeGetContext(node);
   return *baseline;
 }
 

tests/YGConfigTest.cpp

@@ -21,10 +21,16 @@ struct ConfigCloningTest : public ::testing::Test {
   void TearDown() override;
 
   static yoga::Node clonedNode;
-  static YGNodeRef cloneNode(YGNodeConstRef, YGNodeConstRef, size_t) {
+  static YGNodeRef cloneNode(
+      YGNodeConstRef /*unused*/,
+      YGNodeConstRef /*unused*/,
+      size_t /*unused*/) {
     return &clonedNode;
   }
-  static YGNodeRef doNotClone(YGNodeConstRef, YGNodeConstRef, size_t) {
+  static YGNodeRef doNotClone(
+      YGNodeConstRef /*unused*/,
+      YGNodeConstRef /*unused*/,
+      size_t /*unused*/) {
     return nullptr;
   }
 };
@@ -32,7 +38,8 @@ struct ConfigCloningTest : public ::testing::Test {
 TEST_F(ConfigCloningTest, uses_values_provided_by_cloning_callback) {
   config->setCloneNodeCallback(cloneNode);
 
-  yoga::Node node{}, owner{};
+  yoga::Node node{};
+  yoga::Node owner{};
   auto clone = config->cloneNode(&node, &owner, 0);
 
   ASSERT_EQ(clone, &clonedNode);
@@ -43,7 +50,8 @@ TEST_F(
     falls_back_to_regular_cloning_if_callback_returns_null) {
   config->setCloneNodeCallback(doNotClone);
 
-  yoga::Node node{}, owner{};
+  yoga::Node node{};
+  yoga::Node owner{};
   auto clone = config->cloneNode(&node, &owner, 0);
 
   ASSERT_NE(clone, nullptr);

tests/YGDefaultValuesTest.cpp

@@ -12,7 +12,7 @@ TEST(YogaTest, assert_default_values) {
   const YGNodeRef root = YGNodeNew();
 
   ASSERT_EQ(0u, YGNodeGetChildCount(root));
-  ASSERT_EQ(NULL, YGNodeGetChild(root, 1));
+  ASSERT_EQ(nullptr, YGNodeGetChild(root, 1));
 
   ASSERT_EQ(YGDirectionInherit, YGNodeStyleGetDirection(root));
   ASSERT_EQ(YGFlexDirectionColumn, YGNodeStyleGetFlexDirection(root));

tests/YGHadOverflowTest.cpp

@@ -12,8 +12,7 @@ using namespace ::testing;
 
 class YogaTest_HadOverflowTests : public Test {
  protected:
-  YogaTest_HadOverflowTests() {
-    config = YGConfigNew();
+  YogaTest_HadOverflowTests() : config(YGConfigNew()) {
     root = YGNodeNewWithConfig(config);
     YGNodeStyleSetWidth(root, 200);
     YGNodeStyleSetHeight(root, 100);
@@ -21,7 +20,7 @@ class YogaTest_HadOverflowTests : public Test {
     YGNodeStyleSetFlexWrap(root, YGWrapNoWrap);
   }
 
-  ~YogaTest_HadOverflowTests() {
+  ~YogaTest_HadOverflowTests() override {
     YGNodeFreeRecursive(root);
     YGConfigFree(config);
   }

tests/YGMeasureCacheTest.cpp

@@ -50,7 +50,7 @@ static YGSize _measure_84_49(
     float /*height*/,
     YGMeasureMode /*heightMode*/) {
   int* measureCount = (int*)YGNodeGetContext(node);
-  if (measureCount) {
+  if (measureCount != nullptr) {
     (*measureCount)++;
   }
 

tests/YGMeasureModeTest.cpp

@@ -26,8 +26,7 @@ static YGSize _measure(
     YGMeasureMode widthMode,
     float height,
     YGMeasureMode heightMode) {
-  struct _MeasureConstraintList* constraintList =
-      (struct _MeasureConstraintList*)YGNodeGetContext(node);
+  auto* constraintList = (struct _MeasureConstraintList*)YGNodeGetContext(node);
   struct _MeasureConstraint* constraints = constraintList->constraints;
   uint32_t currentIndex = constraintList->length;
   (&constraints[currentIndex])->width = width;
@@ -43,7 +42,7 @@ static YGSize _measure(
 }
 
 TEST(YogaTest, exactly_measure_stretched_child_column) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -70,7 +69,7 @@ TEST(YogaTest, exactly_measure_stretched_child_column) {
 }
 
 TEST(YogaTest, exactly_measure_stretched_child_row) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -98,7 +97,7 @@ TEST(YogaTest, exactly_measure_stretched_child_row) {
 }
 
 TEST(YogaTest, at_most_main_axis_column) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -125,7 +124,7 @@ TEST(YogaTest, at_most_main_axis_column) {
 }
 
 TEST(YogaTest, at_most_cross_axis_column) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -153,7 +152,7 @@ TEST(YogaTest, at_most_cross_axis_column) {
 }
 
 TEST(YogaTest, at_most_main_axis_row) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -181,7 +180,7 @@ TEST(YogaTest, at_most_main_axis_row) {
 }
 
 TEST(YogaTest, at_most_cross_axis_row) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -210,7 +209,7 @@ TEST(YogaTest, at_most_cross_axis_row) {
 }
 
 TEST(YogaTest, flex_child) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -240,7 +239,7 @@ TEST(YogaTest, flex_child) {
 }
 
 TEST(YogaTest, flex_child_with_flex_basis) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -268,7 +267,7 @@ TEST(YogaTest, flex_child_with_flex_basis) {
 }
 
 TEST(YogaTest, overflow_scroll_column) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),
@@ -300,7 +299,7 @@ TEST(YogaTest, overflow_scroll_column) {
 }
 
 TEST(YogaTest, overflow_scroll_row) {
-  struct _MeasureConstraintList constraintList = _MeasureConstraintList{
+  auto constraintList = _MeasureConstraintList{
       0,
       (struct _MeasureConstraint*)malloc(
           10 * sizeof(struct _MeasureConstraint)),

tests/YGMeasureTest.cpp

@@ -15,7 +15,7 @@ static YGSize _measure(
     float /*height*/,
     YGMeasureMode /*heightMode*/) {
   int* measureCount = (int*)YGNodeGetContext(node);
-  if (measureCount) {
+  if (measureCount != nullptr) {
     (*measureCount)++;
   }
 

tests/util/TestUtil.h

@@ -20,7 +20,7 @@ struct TestUtil {
 };
 
 struct ScopedEventSubscription {
-  ScopedEventSubscription(std::function<Event::Subscriber>&&);
+  explicit ScopedEventSubscription(std::function<Event::Subscriber>&&);
   ~ScopedEventSubscription();
 };