Enable Clang Tidy (#1586)

Summary:
X-link: https://github.com/facebook/litho/pull/976

Pull Request resolved: https://github.com/facebook/yoga/pull/1586

X-link: https://github.com/facebook/react-native/pull/43299

Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks.

Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster.

Before:
{F1463947076}

After:
{F1463946802}

This also cleans up all the no-op shallow const parameters in headers.

{F1463943386}

Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D54461054

fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f

tests/YGConfigTest.cpp

@@ -21,10 +21,16 @@ struct ConfigCloningTest : public ::testing::Test {
   void TearDown() override;
 
   static yoga::Node clonedNode;
-  static YGNodeRef cloneNode(YGNodeConstRef, YGNodeConstRef, size_t) {
+  static YGNodeRef cloneNode(
+      YGNodeConstRef /*unused*/,
+      YGNodeConstRef /*unused*/,
+      size_t /*unused*/) {
     return &clonedNode;
   }
-  static YGNodeRef doNotClone(YGNodeConstRef, YGNodeConstRef, size_t) {
+  static YGNodeRef doNotClone(
+      YGNodeConstRef /*unused*/,
+      YGNodeConstRef /*unused*/,
+      size_t /*unused*/) {
     return nullptr;
   }
 };
@@ -32,7 +38,8 @@ struct ConfigCloningTest : public ::testing::Test {
 TEST_F(ConfigCloningTest, uses_values_provided_by_cloning_callback) {
   config->setCloneNodeCallback(cloneNode);
 
-  yoga::Node node{}, owner{};
+  yoga::Node node{};
+  yoga::Node owner{};
   auto clone = config->cloneNode(&node, &owner, 0);
 
   ASSERT_EQ(clone, &clonedNode);
@@ -43,7 +50,8 @@ TEST_F(
     falls_back_to_regular_cloning_if_callback_returns_null) {
   config->setCloneNodeCallback(doNotClone);
 
-  yoga::Node node{}, owner{};
+  yoga::Node node{};
+  yoga::Node owner{};
   auto clone = config->cloneNode(&node, &owner, 0);
 
   ASSERT_NE(clone, nullptr);