Enable Clang Tidy (#1586)

Summary:
X-link: https://github.com/facebook/litho/pull/976

Pull Request resolved: https://github.com/facebook/yoga/pull/1586

X-link: https://github.com/facebook/react-native/pull/43299

Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks.

Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster.

Before:
{F1463947076}

After:
{F1463946802}

This also cleans up all the no-op shallow const parameters in headers.

{F1463943386}

Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D54461054

fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f

tests/YGHadOverflowTest.cpp

@@ -12,8 +12,7 @@ using namespace ::testing;
 
 class YogaTest_HadOverflowTests : public Test {
  protected:
-  YogaTest_HadOverflowTests() {
-    config = YGConfigNew();
+  YogaTest_HadOverflowTests() : config(YGConfigNew()) {
     root = YGNodeNewWithConfig(config);
     YGNodeStyleSetWidth(root, 200);
     YGNodeStyleSetHeight(root, 100);
@@ -21,7 +20,7 @@ class YogaTest_HadOverflowTests : public Test {
     YGNodeStyleSetFlexWrap(root, YGWrapNoWrap);
   }
 
-  ~YogaTest_HadOverflowTests() {
+  ~YogaTest_HadOverflowTests() override {
     YGNodeFreeRecursive(root);
     YGConfigFree(config);
   }