From b9e335ebfd5dd5671bfdd0a055319e9bad4c3530 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Wed, 26 Jun 2024 10:56:18 -0700 Subject: [PATCH] Put generated Java tests in a "generated" folder (#1673) Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1673 Separate the generated Java tests from the non-generated ones, like all the other tests. Reviewed By: javache Differential Revision: D58989535 fbshipit-source-id: 4ffe92d079acdf3ba24731f7f1ef1ae6eba97da5 --- gentest/gentest-driver.ts | 2 +- gentest/gentest-validate.ts | 2 +- .../com/facebook/yoga/YGAbsolutePositionTest.java | 0 .../{ => generated}/com/facebook/yoga/YGAlignContentTest.java | 0 .../{ => generated}/com/facebook/yoga/YGAlignItemsTest.java | 0 .../{ => generated}/com/facebook/yoga/YGAlignSelfTest.java | 0 .../{ => generated}/com/facebook/yoga/YGAndroidNewsFeed.java | 0 .../{ => generated}/com/facebook/yoga/YGAspectRatioTest.java | 0 java/tests/{ => generated}/com/facebook/yoga/YGBorderTest.java | 0 .../{ => generated}/com/facebook/yoga/YGDimensionTest.java | 0 java/tests/{ => generated}/com/facebook/yoga/YGDisplayTest.java | 0 .../{ => generated}/com/facebook/yoga/YGFlexDirectionTest.java | 0 java/tests/{ => generated}/com/facebook/yoga/YGFlexTest.java | 0 .../tests/{ => generated}/com/facebook/yoga/YGFlexWrapTest.java | 0 java/tests/{ => generated}/com/facebook/yoga/YGGapTest.java | 0 .../{ => generated}/com/facebook/yoga/YGIntrinsicSizeTest.java | 0 .../{ => generated}/com/facebook/yoga/YGJustifyContentTest.java | 0 java/tests/{ => generated}/com/facebook/yoga/YGMarginTest.java | 0 .../com/facebook/yoga/YGMinMaxDimensionTest.java | 0 java/tests/{ => generated}/com/facebook/yoga/YGPaddingTest.java | 0 .../{ => generated}/com/facebook/yoga/YGPercentageTest.java | 0 .../tests/{ => generated}/com/facebook/yoga/YGRoundingTest.java | 0 .../{ => generated}/com/facebook/yoga/YGSizeOverflowTest.java | 0 .../{ => generated}/com/facebook/yoga/YGStaticPositionTest.java | 0 24 files changed, 2 insertions(+), 2 deletions(-) rename java/tests/{ => generated}/com/facebook/yoga/YGAbsolutePositionTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGAlignContentTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGAlignItemsTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGAlignSelfTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGAndroidNewsFeed.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGAspectRatioTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGBorderTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGDimensionTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGDisplayTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGFlexDirectionTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGFlexTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGFlexWrapTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGGapTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGIntrinsicSizeTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGJustifyContentTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGMarginTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGMinMaxDimensionTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGPaddingTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGPercentageTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGRoundingTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGSizeOverflowTest.java (100%) rename java/tests/{ => generated}/com/facebook/yoga/YGStaticPositionTest.java (100%) diff --git a/gentest/gentest-driver.ts b/gentest/gentest-driver.ts index 0dc5dc01..d31c783c 100644 --- a/gentest/gentest-driver.ts +++ b/gentest/gentest-driver.ts @@ -106,7 +106,7 @@ for (const fileName of fixtures) { ); await fs.writeFile( - `${yogaDir}/java/tests/com/facebook/yoga/${fileNameNoExtension}.java`, + `${yogaDir}/java/tests/generated/com/facebook/yoga/${fileNameNoExtension}.java`, addSignatureToSourceCode( JSON.parse(logs[1].message.replace(/^[^"]*/, '')).replace( 'YogaTest', diff --git a/gentest/gentest-validate.ts b/gentest/gentest-validate.ts index ad5ce062..406c9c4e 100644 --- a/gentest/gentest-validate.ts +++ b/gentest/gentest-validate.ts @@ -19,7 +19,7 @@ const filesToValidate = await glob( [ 'tests/generated/**/*.{h,cpp}', 'javascript/tests/generated/**/*.test.ts', - 'java/tests/com/facebook/yoga/**/*.java', + 'java/tests/generated/com/facebook/yoga/**/*.java', ], { cwd: yogaRootDir, diff --git a/java/tests/com/facebook/yoga/YGAbsolutePositionTest.java b/java/tests/generated/com/facebook/yoga/YGAbsolutePositionTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGAbsolutePositionTest.java rename to java/tests/generated/com/facebook/yoga/YGAbsolutePositionTest.java diff --git a/java/tests/com/facebook/yoga/YGAlignContentTest.java b/java/tests/generated/com/facebook/yoga/YGAlignContentTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGAlignContentTest.java rename to java/tests/generated/com/facebook/yoga/YGAlignContentTest.java diff --git a/java/tests/com/facebook/yoga/YGAlignItemsTest.java b/java/tests/generated/com/facebook/yoga/YGAlignItemsTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGAlignItemsTest.java rename to java/tests/generated/com/facebook/yoga/YGAlignItemsTest.java diff --git a/java/tests/com/facebook/yoga/YGAlignSelfTest.java b/java/tests/generated/com/facebook/yoga/YGAlignSelfTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGAlignSelfTest.java rename to java/tests/generated/com/facebook/yoga/YGAlignSelfTest.java diff --git a/java/tests/com/facebook/yoga/YGAndroidNewsFeed.java b/java/tests/generated/com/facebook/yoga/YGAndroidNewsFeed.java similarity index 100% rename from java/tests/com/facebook/yoga/YGAndroidNewsFeed.java rename to java/tests/generated/com/facebook/yoga/YGAndroidNewsFeed.java diff --git a/java/tests/com/facebook/yoga/YGAspectRatioTest.java b/java/tests/generated/com/facebook/yoga/YGAspectRatioTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGAspectRatioTest.java rename to java/tests/generated/com/facebook/yoga/YGAspectRatioTest.java diff --git a/java/tests/com/facebook/yoga/YGBorderTest.java b/java/tests/generated/com/facebook/yoga/YGBorderTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGBorderTest.java rename to java/tests/generated/com/facebook/yoga/YGBorderTest.java diff --git a/java/tests/com/facebook/yoga/YGDimensionTest.java b/java/tests/generated/com/facebook/yoga/YGDimensionTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGDimensionTest.java rename to java/tests/generated/com/facebook/yoga/YGDimensionTest.java diff --git a/java/tests/com/facebook/yoga/YGDisplayTest.java b/java/tests/generated/com/facebook/yoga/YGDisplayTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGDisplayTest.java rename to java/tests/generated/com/facebook/yoga/YGDisplayTest.java diff --git a/java/tests/com/facebook/yoga/YGFlexDirectionTest.java b/java/tests/generated/com/facebook/yoga/YGFlexDirectionTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGFlexDirectionTest.java rename to java/tests/generated/com/facebook/yoga/YGFlexDirectionTest.java diff --git a/java/tests/com/facebook/yoga/YGFlexTest.java b/java/tests/generated/com/facebook/yoga/YGFlexTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGFlexTest.java rename to java/tests/generated/com/facebook/yoga/YGFlexTest.java diff --git a/java/tests/com/facebook/yoga/YGFlexWrapTest.java b/java/tests/generated/com/facebook/yoga/YGFlexWrapTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGFlexWrapTest.java rename to java/tests/generated/com/facebook/yoga/YGFlexWrapTest.java diff --git a/java/tests/com/facebook/yoga/YGGapTest.java b/java/tests/generated/com/facebook/yoga/YGGapTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGGapTest.java rename to java/tests/generated/com/facebook/yoga/YGGapTest.java diff --git a/java/tests/com/facebook/yoga/YGIntrinsicSizeTest.java b/java/tests/generated/com/facebook/yoga/YGIntrinsicSizeTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGIntrinsicSizeTest.java rename to java/tests/generated/com/facebook/yoga/YGIntrinsicSizeTest.java diff --git a/java/tests/com/facebook/yoga/YGJustifyContentTest.java b/java/tests/generated/com/facebook/yoga/YGJustifyContentTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGJustifyContentTest.java rename to java/tests/generated/com/facebook/yoga/YGJustifyContentTest.java diff --git a/java/tests/com/facebook/yoga/YGMarginTest.java b/java/tests/generated/com/facebook/yoga/YGMarginTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGMarginTest.java rename to java/tests/generated/com/facebook/yoga/YGMarginTest.java diff --git a/java/tests/com/facebook/yoga/YGMinMaxDimensionTest.java b/java/tests/generated/com/facebook/yoga/YGMinMaxDimensionTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGMinMaxDimensionTest.java rename to java/tests/generated/com/facebook/yoga/YGMinMaxDimensionTest.java diff --git a/java/tests/com/facebook/yoga/YGPaddingTest.java b/java/tests/generated/com/facebook/yoga/YGPaddingTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGPaddingTest.java rename to java/tests/generated/com/facebook/yoga/YGPaddingTest.java diff --git a/java/tests/com/facebook/yoga/YGPercentageTest.java b/java/tests/generated/com/facebook/yoga/YGPercentageTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGPercentageTest.java rename to java/tests/generated/com/facebook/yoga/YGPercentageTest.java diff --git a/java/tests/com/facebook/yoga/YGRoundingTest.java b/java/tests/generated/com/facebook/yoga/YGRoundingTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGRoundingTest.java rename to java/tests/generated/com/facebook/yoga/YGRoundingTest.java diff --git a/java/tests/com/facebook/yoga/YGSizeOverflowTest.java b/java/tests/generated/com/facebook/yoga/YGSizeOverflowTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGSizeOverflowTest.java rename to java/tests/generated/com/facebook/yoga/YGSizeOverflowTest.java diff --git a/java/tests/com/facebook/yoga/YGStaticPositionTest.java b/java/tests/generated/com/facebook/yoga/YGStaticPositionTest.java similarity index 100% rename from java/tests/com/facebook/yoga/YGStaticPositionTest.java rename to java/tests/generated/com/facebook/yoga/YGStaticPositionTest.java