Add tests for row-gap and column-gap
Summary: This adds the fixtures from https://github.com/facebook/yoga/pull/1116 and generates tests. This adds a good amount of coverage, but I plan to follow up with a diff adding a bit more, e.g. for interactions with flex direction of column when we should no-op, etc. I also discovered the current fixtures do not allow testing shorthand props like "gap" without changes. This also updates the `webdrivers` gem to respond to a break with chromedriver on m1 macs from 4 days ago https://github.com/titusfortner/webdrivers/pull/239. Reviewed By: yungsters Differential Revision: D39922413 fbshipit-source-id: dfc7bda894be8dfcb24e25c19a4df0b09a72ce7e
This commit is contained in:
committed by
Facebook GitHub Bot
parent
8e29e7c1e1
commit
c2a0ccf0d4
@@ -18,7 +18,7 @@ GEM
|
||||
watir (6.19.1)
|
||||
regexp_parser (>= 1.2, < 3)
|
||||
selenium-webdriver (>= 3.142.7)
|
||||
webdrivers (5.1.0)
|
||||
webdrivers (5.2.0)
|
||||
nokogiri (~> 1.6)
|
||||
rubyzip (>= 1.3.0)
|
||||
selenium-webdriver (~> 4.0)
|
||||
@@ -29,7 +29,7 @@ PLATFORMS
|
||||
|
||||
DEPENDENCIES
|
||||
watir (~> 6.19.0)
|
||||
webdrivers (~> 5.1.0)
|
||||
webdrivers (~> 5.2.0)
|
||||
|
||||
BUNDLED WITH
|
||||
2.1.4
|
||||
|
Reference in New Issue
Block a user