Add tests for row-gap and column-gap

Browse Source

Summary:
This adds the fixtures from https://github.com/facebook/yoga/pull/1116 and generates tests.

This adds a good amount of coverage, but I plan to follow up with a diff adding a bit more, e.g. for interactions with flex direction of column when we should no-op, etc. I also discovered the current fixtures do not allow testing shorthand props like "gap" without changes.

This also updates the `webdrivers` gem to respond to a break with chromedriver on m1 macs from 4 days ago https://github.com/titusfortner/webdrivers/pull/239.

Reviewed By: yungsters

Differential Revision: D39922413

fbshipit-source-id: dfc7bda894be8dfcb24e25c19a4df0b09a72ce7e

...

This commit is contained in:

Nick Gerleman

2022-10-13 08:18:49 -07:00

committed by Facebook GitHub Bot

parent 8e29e7c1e1

commit c2a0ccf0d4

7 changed files with 6739 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

1637

tests/YGGapTest.cpp Normal file

File diff suppressed because it is too large Load Diff