DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Use const where possible

Browse Source 
Summary: Use const where possible. This does not use const for all variables as that would require too much refactoring for one diff. It does however use const where currently possible as well as does some small refactoring to enable const usage in more locations. Striving for 100% const usage leads to code with is easier to reason about as a reference will always reference the same value. The compiler will also assist if you accidentally override a reference.

Reviewed By: IanChilds

Differential Revision: D3741999

fbshipit-source-id: 1ba7da5784c3047f2d4c03746890192f724aa65e
This commit is contained in:
Emil Sjolander
2016-08-22 06:58:13 -07:00
committed by Facebook Github Bot 6
parent 4bcefd8845
commit ca72b2b796
10 changed files with 328 additions and 332 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/CSSLayoutTestUtils/CSSLayoutTestUtils.c
View File

@@ -26,11 +26,11 @@ __forceinline const float fminf(const float a, const float b) {
#endif
#endif
static bool eq(float a, float b) {
static bool eq(const float a, const float b) {
return fabs(a - b) < 0.0001;
}
static bool are_layout_equal(CSSNode *a, CSSNode *b) {
static bool are_layout_equal(const CSSNodeRef a, const CSSNodeRef b) {
if (!eq(a->layout.dimensions[CSSDimensionWidth], b->layout.dimensions[CSSDimensionWidth]) ||
!eq(a->layout.dimensions[CSSDimensionHeight], b->layout.dimensions[CSSDimensionHeight]) ||
!eq(a->layout.position[CSSEdgeTop], b->layout.position[CSSEdgeTop]) ||
@@ -38,7 +38,7 @@ static bool are_layout_equal(CSSNode *a, CSSNode *b) {
!eq(CSSNodeChildCount(a), CSSNodeChildCount(b))) {
return false;
}
for (int i = 0; i < CSSNodeChildCount(a); ++i) {
for (uint32_t i = 0; i < CSSNodeChildCount(a); ++i) {
if (!are_layout_equal(CSSNodeGetChild(a, i), CSSNodeGetChild(b, i))) {
return false;
}
@@ -47,12 +47,14 @@ static bool are_layout_equal(CSSNode *a, CSSNode *b) {
}
CSSSize measure(void *context,
float width,
float availableWidth,
CSSMeasureMode widthMode,
float height,
float availableHeight,
CSSMeasureMode heightMode) {
const char *text = (const char *) context;
CSSSize result;
float width = availableWidth;
float height = availableHeight;
if (strcmp(text, SMALL_TEXT) == 0) {
if (widthMode == CSSMeasureModeUndefined) {
width = 1000000;
@@ -108,18 +110,18 @@ CSSSize measure(void *context,
return result;
}
bool test(CSSNode *style, CSSNode *expected_layout) {
bool test(const CSSNodeRef style, const CSSNodeRef expected_layout) {
CSSNodeCalculateLayout(style, CSSUndefined, CSSUndefined, (CSSDirection) -1);
return are_layout_equal(style, expected_layout);
}
CSSNode *new_test_css_node(void) {
CSSNode *node = CSSNodeNew();
CSSNodeRef new_test_css_node() {
CSSNodeRef node = CSSNodeNew();
return node;
}
void init_css_node_children(CSSNode *node, int childCount) {
for (int i = 0; i < childCount; ++i) {
void init_css_node_children(const CSSNodeRef node, const uint32_t childCount) {
for (uint32_t i = 0; i < childCount; ++i) {
CSSNodeInsertChild(node, new_test_css_node(), 0);
}
}