Code review comments

This commit is contained in:
Pavel Mazurin
2017-08-24 11:13:48 +02:00
parent 6366ee45ab
commit d12400c904

View File

@@ -102,6 +102,7 @@ static YGConfigRef globalConfig;
@interface YGLayout () @interface YGLayout ()
@property (nonatomic, weak, readonly) UIView *view; @property (nonatomic, weak, readonly) UIView *view;
@property (nonatomic, assign, readonly) BOOL isUIView;
@end @end
@@ -126,6 +127,7 @@ static YGConfigRef globalConfig;
YGNodeSetContext(_node, (__bridge void *) view); YGNodeSetContext(_node, (__bridge void *) view);
_isEnabled = NO; _isEnabled = NO;
_isIncludedInLayout = YES; _isIncludedInLayout = YES;
_isUIView = [view isMemberOfClass:[UIView class]];
} }
return self; return self;
@@ -307,7 +309,7 @@ static YGSize YGMeasureView(
CGSize sizeThatFits = CGSizeZero; CGSize sizeThatFits = CGSizeZero;
// Fix for https://github.com/facebook/yoga/issues/606 // Fix for https://github.com/facebook/yoga/issues/606
if (![view isMemberOfClass:[UIView class]] || [view.subviews count] > 0) { if (!view.yoga.isUIView || [view.subviews count] > 0) {
sizeThatFits = [view sizeThatFits:(CGSize) { sizeThatFits = [view sizeThatFits:(CGSize) {
.width = constrainedWidth, .width = constrainedWidth,
.height = constrainedHeight, .height = constrainedHeight,