From d1d9326fa4dd1af87d33fbecdd79e6816c713ca5 Mon Sep 17 00:00:00 2001 From: Emil Sjolander Date: Tue, 18 Oct 2016 10:01:16 -0700 Subject: [PATCH] Use switch instead of ifelse chain Summary: easier to read Reviewed By: gkassabli Differential Revision: D4036445 fbshipit-source-id: 2159946f53507ff3d7505795e5baa5f820cdb65c --- CSSLayout/CSSLayout.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/CSSLayout/CSSLayout.c b/CSSLayout/CSSLayout.c index 3d2e2717..321adac4 100644 --- a/CSSLayout/CSSLayout.c +++ b/CSSLayout/CSSLayout.c @@ -1855,15 +1855,21 @@ static void layoutNodeImpl(const CSSNodeRef node, float crossDimLead = 0; float currentLead = leadingPaddingAndBorderCross; - const CSSAlign alignContent = node->style.alignContent; - if (alignContent == CSSAlignFlexEnd) { - currentLead += remainingAlignContentDim; - } else if (alignContent == CSSAlignCenter) { - currentLead += remainingAlignContentDim / 2; - } else if (alignContent == CSSAlignStretch) { - if (availableInnerCrossDim > totalLineCrossDim) { - crossDimLead = (remainingAlignContentDim / lineCount); - } + switch (node->style.alignContent) { + case CSSAlignFlexEnd: + currentLead += remainingAlignContentDim; + break; + case CSSAlignCenter: + currentLead += remainingAlignContentDim / 2; + break; + case CSSAlignStretch: + if (availableInnerCrossDim > totalLineCrossDim) { + crossDimLead = (remainingAlignContentDim / lineCount); + } + break; + case CSSAlignAuto: + case CSSAlignFlexStart: + break; } uint32_t endIndex = 0;