From dd2346f8ace4dd34d43eea85cd467efbdde3eb6d Mon Sep 17 00:00:00 2001 From: Emil Sjolander Date: Wed, 17 Aug 2016 06:35:05 -0700 Subject: [PATCH] Document format.sh Summary: Mention format.sh script in README and CONTRIBUTING docs Reviewed By: IanChilds Differential Revision: D3728789 fbshipit-source-id: 1d5d99dc627b6cb87898d282aae8adfcaeec7c14 --- CONTRIBUTING | 4 +--- README.md | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING b/CONTRIBUTING index 1d8ffc28..eac38f3d 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -29,9 +29,7 @@ disclosure of security bugs. In those cases, please go through the process outlined on that page and do not file a public issue. ## Coding Style -* 2 spaces for indentation rather than tabs -* 80 character line length -* ... +* format.sh ## License By contributing to css-layout, you agree that your contributions will be licensed diff --git a/README.md b/README.md index 9c2bf2d1..577594ee 100644 --- a/README.md +++ b/README.md @@ -96,7 +96,7 @@ root.getLayoutHeight(); ``` ## Contributing -To contribute to CSSLayout you need to first install [buck](https://buckbuild.com) which is the build system used by CSSLayout. CSSLayout is implemented in C with language bindings for Java. When making changes to `CSSLayout/CSSLayout.h` please ensure to update `java/jni/CSSJNI.h` and `java/com/facebook/csslayout/CSSNode.java` to reflect the API change. +To contribute to CSSLayout you need to first install [buck](https://buckbuild.com) which is the build system used by CSSLayout. CSSLayout is implemented in C with language bindings for Java. When making changes to `CSSLayout/CSSLayout.h` please ensure to update `java/jni/CSSJNI.h` and `java/com/facebook/csslayout/CSSNode.java` to reflect the API change. Before submitting any code please run `format.sh` to ensure the code matches the project's code style. Before making any larger changes to CSSLayout please open an issue with a RFC so the changes can be discussed first. Generally we are very open to changes and improvements that will benefit the community.