Use Float.compare in java equals
Summary: Handles nans. Also if the unit is undefined there is no need to check the value. Reviewed By: astreet Differential Revision: D4531805 fbshipit-source-id: 723e15381e9fa39837a4c99f726501eda26af11b
This commit is contained in:
committed by
Facebook Github Bot
parent
168ae4099d
commit
e0e2a61dfc
@@ -33,7 +33,9 @@ public class YogaValue {
|
||||
public boolean equals(Object other) {
|
||||
if (other instanceof YogaValue) {
|
||||
final YogaValue otherValue = (YogaValue) other;
|
||||
return value == otherValue.value && unit == otherValue.unit;
|
||||
if (unit == otherValue.unit) {
|
||||
return unit == YogaUnit.UNDEFINED || Float.compare(value, otherValue.value) == 0;
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
Reference in New Issue
Block a user