Fix measure inner dimensions (#1114)
Summary: `YGFloatIsUndefined(collectedFlexItemsValues.totalFlexGrowFactors) && collectedFlexItemsValues.totalFlexGrowFactors == 0` is not reachable. Pull Request resolved: https://github.com/facebook/yoga/pull/1114 Reviewed By: NickGerleman Differential Revision: D40203817 Pulled By: NickGerleman fbshipit-source-id: 46a8c19dc0e097f4c28e7f48135f0382a557764a
This commit is contained in:
committed by
Facebook GitHub Bot
parent
48cbf3802e
commit
efdcfec88f
@@ -2952,10 +2952,10 @@ static void YGNodelayoutImpl(
|
|||||||
availableInnerMainDim = maxInnerMainDim;
|
availableInnerMainDim = maxInnerMainDim;
|
||||||
} else {
|
} else {
|
||||||
if (!node->getConfig()->useLegacyStretchBehaviour &&
|
if (!node->getConfig()->useLegacyStretchBehaviour &&
|
||||||
((YGFloatIsUndefined(
|
((!YGFloatIsUndefined(
|
||||||
collectedFlexItemsValues.totalFlexGrowFactors) &&
|
collectedFlexItemsValues.totalFlexGrowFactors) &&
|
||||||
collectedFlexItemsValues.totalFlexGrowFactors == 0) ||
|
collectedFlexItemsValues.totalFlexGrowFactors == 0) ||
|
||||||
(YGFloatIsUndefined(node->resolveFlexGrow()) &&
|
(!YGFloatIsUndefined(node->resolveFlexGrow()) &&
|
||||||
node->resolveFlexGrow() == 0))) {
|
node->resolveFlexGrow() == 0))) {
|
||||||
// If we don't have any children to flex or we can't flex the node
|
// If we don't have any children to flex or we can't flex the node
|
||||||
// itself, space we've used is all space we need. Root node also
|
// itself, space we've used is all space we need. Root node also
|
||||||
|
Reference in New Issue
Block a user