diff --git a/java/com/facebook/yoga/YogaLogger.java b/java/com/facebook/yoga/YogaLogger.java index 2fd4d821..d9411061 100644 --- a/java/com/facebook/yoga/YogaLogger.java +++ b/java/com/facebook/yoga/YogaLogger.java @@ -15,5 +15,5 @@ import com.facebook.proguard.annotations.DoNotStrip; @DoNotStrip public interface YogaLogger { @DoNotStrip - void log(YogaNode node, YogaLogLevel level, String message); + void log(YogaLogLevel level, String message); } diff --git a/java/jni/YGJNI.cpp b/java/jni/YGJNI.cpp index 6a1a790a..f23d0f2b 100644 --- a/java/jni/YGJNI.cpp +++ b/java/jni/YGJNI.cpp @@ -311,13 +311,10 @@ static int YGJNILogFunc( auto jloggerPtr = static_cast*>(YGConfigGetContext(config)); if (jloggerPtr != nullptr) { - if (auto obj = YGNodeJobject(node, layoutContext)) { - (*jloggerPtr) - ->log( - obj, - JYogaLogLevel::fromInt(level), - Environment::current()->NewStringUTF(buffer.data())); - } + (*jloggerPtr) + ->log( + JYogaLogLevel::fromInt(level), + Environment::current()->NewStringUTF(buffer.data())); } return result; diff --git a/java/jni/YGJTypes.cpp b/java/jni/YGJTypes.cpp index 032be5c5..012a2837 100644 --- a/java/jni/YGJTypes.cpp +++ b/java/jni/YGJTypes.cpp @@ -33,12 +33,10 @@ facebook::jni::local_ref JYogaLogLevel::fromInt(jint logLevel) { } void JYogaLogger::log( - facebook::jni::alias_ref node, facebook::jni::alias_ref logLevel, jstring message) { static auto javaMethod = - javaClassLocal() - ->getMethod, alias_ref, jstring)>("log"); - javaMethod(self(), node, logLevel, message); + javaClassLocal()->getMethod, jstring)>( + "log"); + javaMethod(self(), logLevel, message); } diff --git a/java/jni/YGJTypes.h b/java/jni/YGJTypes.h index 0c4bc9a8..6561ce2d 100644 --- a/java/jni/YGJTypes.h +++ b/java/jni/YGJTypes.h @@ -28,10 +28,7 @@ struct JYogaLogLevel : public facebook::jni::JavaClass { struct JYogaLogger : public facebook::jni::JavaClass { static constexpr auto kJavaDescriptor = "Lcom/facebook/yoga/YogaLogger;"; - void log( - facebook::jni::alias_ref, - facebook::jni::alias_ref, - jstring); + void log(facebook::jni::alias_ref, jstring); }; class PtrJNodeMap { diff --git a/java/tests/com/facebook/yoga/YogaLoggerTest.java b/java/tests/com/facebook/yoga/YogaLoggerTest.java index b111f872..1f56a923 100644 --- a/java/tests/com/facebook/yoga/YogaLoggerTest.java +++ b/java/tests/com/facebook/yoga/YogaLoggerTest.java @@ -17,7 +17,7 @@ public class YogaLoggerTest { final YogaConfig config = YogaConfigFactory.create(); YogaLogger logger = new YogaLogger() { @Override - public void log(YogaNode yogaNode, YogaLogLevel level, String message) { + public void log(YogaLogLevel level, String message) { } }; config.setLogger(logger);