DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fixing using flex in root node

Browse Source 
Summary: We should always try to make root node as small as possible, while previously this wasn't functioning this way

Reviewed By: emilsjolander

Differential Revision: D5071164

fbshipit-source-id: b8afef42477d0ed87d0c9fcfd26349e0a0babd6e
This commit is contained in:
Georgiy Kassabli
2017-05-17 07:21:52 -07:00
committed by Facebook Github Bot
parent 49bccf47fa
commit f2612192c5
6 changed files with 822 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gentest/fixtures/YGMinMaxDimensionTest.html
View File

@@ -62,6 +62,25 @@
</div>
</div>
<div id="flex_root_ignored" style="width: 100px; min-height: 100px; max-height:500px;flex-grow:1">
<div style="flex-basis:200px; flex-grow:1;"></div>
<div style="height:100px; "></div>
</div>
<div id="flex_grow_root_minimized" style="width: 100px; min-height: 100px; max-height:500px">
<div style="min-height: 100px; max-height:500px;flex-grow:1">
<div style="flex-basis:200px; flex-grow:1;"></div>
<div style="height:100px; "></div>
</div>
</div>
<div id="flex_grow_height_maximized" style="width: 100px; height:500px">
<div style="min-height: 100px; max-height:500px;flex-grow:1">
<div style="flex-basis:200px; flex-grow:1;"></div>
<div style="height:100px; "></div>
</div>
</div>
<div id="flex_grow_within_constrained_min_row" style="min-width: 100px; height:100px; flex-direction: row;">
<div style="flex-grow:1;"></div>
<div style="width: 50px;"></div>