From f2b5d0fef7e8b92eab511e1f8fe8a2c06cd6ce0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20W=C3=B6hrl?= Date: Tue, 25 Apr 2017 11:27:29 -0700 Subject: [PATCH] Mark some fields as readonly and reuse index value in RemoveChild Summary: Mark some fields as readonly and reuse index value in RemoveChild. Closes https://github.com/facebook/yoga/pull/516 Reviewed By: emilsjolander Differential Revision: D4921809 Pulled By: splhack fbshipit-source-id: 261a7910675d93be165c16ee53a83c02b15925f1 --- csharp/Facebook.Yoga/YogaNode.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/csharp/Facebook.Yoga/YogaNode.cs b/csharp/Facebook.Yoga/YogaNode.cs index 2ca4a61e..4d2aec2b 100644 --- a/csharp/Facebook.Yoga/YogaNode.cs +++ b/csharp/Facebook.Yoga/YogaNode.cs @@ -26,8 +26,8 @@ namespace Facebook.Yoga { public partial class YogaNode : IEnumerable { - private Native.YGNodeHandle _ygNode; - private YogaConfig _config; + private readonly Native.YGNodeHandle _ygNode; + private readonly YogaConfig _config; private WeakReference _parent; private List _children; private MeasureFunction _measureFunction; @@ -586,7 +586,7 @@ namespace Facebook.Yoga int index = IndexOf(child); if (index >= 0) { - RemoveAt(IndexOf(child)); + RemoveAt(index); } }