From f4226d3ff509be6059574fd88f57304e0a030ab6 Mon Sep 17 00:00:00 2001
From: Pierre Renaux <pierre@talansoft.com>
Date: Fri, 8 May 2015 14:51:05 +0800
Subject: [PATCH] [src/Layout-test-utils.js]: Added testMeasurePrecision and
 inplaceRoundNumbersInObject which snap the numbers to pixels so that we don't
 have to re-adjust for each browser version (Chrome 42 changed their
 computation, it can output floating point values for dom elements) ;

---
 src/Layout-test-utils.js | 41 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/src/Layout-test-utils.js b/src/Layout-test-utils.js
index 3e1efaaa..f58dcf67 100644
--- a/src/Layout-test-utils.js
+++ b/src/Layout-test-utils.js
@@ -10,6 +10,18 @@
 
 var layoutTestUtils = (function() {
 
+  //
+  // Sets the test cases precision, by default set to 1.0, aka pixel precision
+  // (assuming the browser does pixel snapping - and that we're ok with being
+  // 'only' pixel perfect).
+  //
+  // Set it to '10' for .1 precision, etc... in theory the browser is doing
+  // 'pixel' snapping so 1.0 should do, the code is left for clarity...
+  //
+  // Set it to undefined to disable and use full precision.
+  //
+  var testMeasurePrecision = 1.0;
+
   if (typeof jasmine !== 'undefined') {
     jasmine.matchersUtil.buildFailureMessage = function () {
       var args = Array.prototype.slice.call(arguments, 0),
@@ -227,11 +239,33 @@ var layoutTestUtils = (function() {
     return layout;
   }
 
+  function inplaceRoundNumbersInObject(aObj) {
+    if (!testMeasurePrecision) // undefined/0, disables rounding
+      return;
+
+    for (var key in aObj) {
+      if (!aObj.hasOwnProperty(key))
+        continue;
+      var val = aObj[key];
+      switch (typeof(val)) {
+      case 'number': {
+        aObj[key] = Math.floor((val*testMeasurePrecision)+0.5)/testMeasurePrecision;
+        break;
+      }
+      case 'object': {
+        inplaceRoundNumbersInObject(val);
+        break;
+      }
+      }
+    }
+  }
+
   function nameLayout(name, layout) {
     var namedLayout = {name: name};
     for (var key in layout) {
       namedLayout[key] = layout[key];
     }
+    inplaceRoundNumbersInObject(namedLayout);
     return namedLayout;
   }
 
@@ -363,7 +397,7 @@ var layoutTestUtils = (function() {
     smallWidth: 34.671875,
     smallHeight: 18,
     bigWidth: 172.421875,
-    bigHeight: 36,
+    bigHeight: 37,
     bigMinWidth: 100.4375
   };
 
@@ -380,6 +414,11 @@ var layoutTestUtils = (function() {
     };
   }
 
+  // round the text sizes so that we dont have to update it for every browser
+  // update, assumes we're ok with pixel precision
+  inplaceRoundNumbersInObject(preDefinedTextSizes);
+  inplaceRoundNumbersInObject(textSizes);
+
   return {
     texts: texts,
     textSizes: textSizes,