DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Make position static behave like position static (#1482)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1482

X-link: https://github.com/facebook/react-native/pull/41685

This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild`

Reviewed By: NickGerleman

Differential Revision: D51293606

fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
This commit is contained in:
Joe Vilches
2023-12-07 21:25:45 -08:00
committed by Facebook GitHub Bot
parent 1b146cd8a8
commit f6c4a8e8e4
5 changed files with 72 additions and 174 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
gentest/fixtures/YGStaticPositionTest.html
View File

@@ -10,7 +10,7 @@
</div>
</div>
<div id="static_position_absolute_child_insets_relative_to_positioned_ancestor" data-disabled="true">
<div id="static_position_absolute_child_insets_relative_to_positioned_ancestor">
<div style="width: 200px; height: 200px; position: relative">
<div style="height: 100px; width: 100px; margin-left: 100px; position: static">
<div style="height: 50px; width: 50px; position: absolute; top: 50px; left: 50px;">
@@ -19,7 +19,7 @@
</div>
</div>
<div id="static_position_absolute_child_insets_relative_to_positioned_ancestor_deep" data-disabled="true">
<div id="static_position_absolute_child_insets_relative_to_positioned_ancestor_deep">
<div style="width: 200px; height: 200px; position: relative">
<div style="height: 100px; width: 100px; margin-left: 100px; position: static">
<div style="height: 100px; width: 100px; margin-left: 100px; position: static">
@@ -34,7 +34,7 @@
</div>
</div>
<div id="static_position_absolute_child_width_percentage" data-disabled="true">
<div id="static_position_absolute_child_width_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50%; position: absolute">
@@ -43,7 +43,7 @@
</div>
</div>
<div id="static_position_relative_child_width_percentage" data-disabled="true">
<div id="static_position_relative_child_width_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50%; position: relative">
@@ -52,7 +52,7 @@
</div>
</div>
<div id="static_position_static_child_width_percentage" data-disabled="true">
<div id="static_position_static_child_width_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50%; position: static">
@@ -61,7 +61,7 @@
</div>
</div>
<div id="static_position_absolute_child_height_percentage" data-disabled="true">
<div id="static_position_absolute_child_height_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50%; width: 50px; position: absolute">
@@ -70,7 +70,7 @@
</div>
</div>
<div id="static_position_relative_child_height_percentage" data-disabled="true">
<div id="static_position_relative_child_height_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50%; width: 50px; position: relative">
@@ -79,7 +79,7 @@
</div>
</div>
<div id="static_position_static_child_height_percentage" data-disabled="true">
<div id="static_position_static_child_height_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50%; width: 50px; position: static">
@@ -88,7 +88,7 @@
</div>
</div>
<div id="static_position_absolute_child_left_percentage" data-disabled="true">
<div id="static_position_absolute_child_left_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; left: 50%; position: absolute">
@@ -97,7 +97,7 @@
</div>
</div>
<div id="static_position_relative_child_left_percentage" data-disabled="true">
<div id="static_position_relative_child_left_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; left: 50%; position: relative">
@@ -106,7 +106,7 @@
</div>
</div>
<div id="static_position_static_child_left_percentage" data-disabled="true">
<div id="static_position_static_child_left_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; left: 50%; position: static">
@@ -115,7 +115,7 @@
</div>
</div>
<div id="static_position_absolute_child_right_percentage" data-disabled="true">
<div id="static_position_absolute_child_right_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; right: 50%; position: absolute">
@@ -124,7 +124,7 @@
</div>
</div>
<div id="static_position_relative_child_right_percentage" data-disabled="true">
<div id="static_position_relative_child_right_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; right: 50%; position: relative">
@@ -133,7 +133,7 @@
</div>
</div>
<div id="static_position_static_child_right_percentage" data-disabled="true">
<div id="static_position_static_child_right_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; right: 50%; position: static">
@@ -142,7 +142,7 @@
</div>
</div>
<div id="static_position_absolute_child_top_percentage" data-disabled="true">
<div id="static_position_absolute_child_top_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; top: 50%; position: absolute">
@@ -151,7 +151,7 @@
</div>
</div>
<div id="static_position_relative_child_top_percentage" data-disabled="true">
<div id="static_position_relative_child_top_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; top: 50%; position: relative">
@@ -160,7 +160,7 @@
</div>
</div>
<div id="static_position_static_child_top_percentage" data-disabled="true">
<div id="static_position_static_child_top_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; top: 50%; position: static">
@@ -169,7 +169,7 @@
</div>
</div>
<div id="static_position_absolute_child_bottom_percentage" data-disabled="true">
<div id="static_position_absolute_child_bottom_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; bottom: 50%; position: absolute">
@@ -178,7 +178,7 @@
</div>
</div>
<div id="static_position_relative_child_bottom_percentage" data-disabled="true">
<div id="static_position_relative_child_bottom_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; bottom: 50%; position: relative">
@@ -187,7 +187,7 @@
</div>
</div>
<div id="static_position_static_child_bottom_percentage" data-disabled="true">
<div id="static_position_static_child_bottom_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; bottom: 50%; position: static">
@@ -196,7 +196,7 @@
</div>
</div>
<div id="static_position_absolute_child_margin_percentage" data-disabled="true">
<div id="static_position_absolute_child_margin_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; margin: 50%; position: absolute">
@@ -205,7 +205,7 @@
</div>
</div>
<div id="static_position_relative_child_margin_percentage" data-disabled="true">
<div id="static_position_relative_child_margin_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; margin: 50%; position: relative">
@@ -214,7 +214,7 @@
</div>
</div>
<div id="static_position_static_child_margin_percentage" data-disabled="true">
<div id="static_position_static_child_margin_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; margin: 50%; position: static">
@@ -223,7 +223,7 @@
</div>
</div>
<div id="static_position_absolute_child_padding_percentage" data-disabled="true">
<div id="static_position_absolute_child_padding_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; padding: 50%; position: absolute">
@@ -232,7 +232,7 @@
</div>
</div>
<div id="static_position_relative_child_padding_percentage" data-disabled="true">
<div id="static_position_relative_child_padding_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; padding: 50%; position: relative">
@@ -241,7 +241,7 @@
</div>
</div>
<div id="static_position_static_child_padding_percentage" data-disabled="true">
<div id="static_position_static_child_padding_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; padding: 50%; position: static">
@@ -250,7 +250,7 @@
</div>
</div>
<div id="static_position_absolute_child_border_percentage" data-disabled="true">
<div id="static_position_absolute_child_border_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; border: 50%; position: absolute">
@@ -259,7 +259,7 @@
</div>
</div>
<div id="static_position_relative_child_border_percentage" data-disabled="true">
<div id="static_position_relative_child_border_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; border: 50%; position: relative">
@@ -268,7 +268,7 @@
</div>
</div>
<div id="static_position_static_child_border_percentage" data-disabled="true">
<div id="static_position_static_child_border_percentage">
<div style="width: 200px; height: 200px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50px; border: 50%; position: static">
@@ -277,7 +277,7 @@
</div>
</div>
<div id="static_position_absolute_child_containing_block_padding_box" data-disabled="true">
<div id="static_position_absolute_child_containing_block_padding_box">
<div style="width: 400px; height: 400px; padding: 100px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50%; position: absolute">
@@ -286,7 +286,7 @@
</div>
</div>
<div id="static_position_relative_child_containing_block_padding_box" data-disabled="true">
<div id="static_position_relative_child_containing_block_padding_box">
<div style="width: 400px; height: 400px; padding: 100px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50%; position: relative">
@@ -295,7 +295,7 @@
</div>
</div>
<div id="static_position_static_child_containing_block_padding_box" data-disabled="true">
<div id="static_position_static_child_containing_block_padding_box">
<div style="width: 400px; height: 400px; padding: 100px; position: relative">
<div style="height:100px; width: 100px; position: static">
<div style="height: 50px; width: 50%; position: static">
@@ -311,14 +311,14 @@
</div>
</div>
<div id="static_position_relative_child_containing_block_content_box" data-disabled="true">
<div id="static_position_relative_child_containing_block_content_box">
<div style="width: 400px; height: 400px; padding: 100px; position: relative">
<div style="height:50px; width: 50%; position: relative">
</div>
</div>
</div>
<div id="static_position_static_child_containing_block_content_box" data-disabled="true">
<div id="static_position_static_child_containing_block_content_box">
<div style="width: 400px; height: 400px; padding: 100px; position: relative">
<div style="height:50px; width: 50%; position: static">
</div>