Use fbsource clang-format config

Summary:
This mirrors the clang-format config used by fbsource to Yoga.

They are pretty similar, except for an annoying habit where Yoga's previous forced small functions in headers to be a a single line, so you would get a combination of multiline and single line functions next to each other which are hard to read. That is what motivated this change.

It also enforces header ordering (yay). I don't think we have any side-effect causing headers, so this should be safe.

Reviewed By: yungsters

Differential Revision: D49248994

fbshipit-source-id: 66998395e7c0158ff9d9fb1bee44e8401bdd8f21
This commit is contained in:
Nick Gerleman
2023-09-13 20:12:55 -07:00
committed by Facebook GitHub Bot
parent 9d21e3e300
commit f9c2c27d33
51 changed files with 522 additions and 470 deletions

View File

@@ -1,61 +1,3 @@
Language: Cpp
AccessModifierOffset: -2
AlignAfterOpenBracket: AlwaysBreak
AlignConsecutiveAssignments: false
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
AlignOperands: false
AlignTrailingComments: false
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: true
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: Yes
BinPackArguments: false
BinPackParameters: false
BreakBeforeBinaryOperators: false
BreakBeforeBraces: Attach
BreakBeforeTernaryOperators: true
BreakConstructorInitializers: BeforeColon
BreakInheritanceList: BeforeColon
BreakStringLiterals: true
ColumnLimit: 80
CompactNamespaces: false
ConstructorInitializerAllOnOneLineOrOnePerLine: true
ConstructorInitializerIndentWidth: 4
ContinuationIndentWidth: 4
Cpp11BracedListStyle: true
DerivePointerAlignment: false
FixNamespaceComments: true
IndentCaseLabels: true
IndentPPDirectives: None
IndentWidth: 2
IndentWrappedFunctionNames: false
MaxEmptyLinesToKeep: 1
NamespaceIndentation: None
PenaltyReturnTypeOnItsOwnLine: 2000
PointerAlignment: Left
ReflowComments: true
SortIncludes: false
SortUsingDeclarations: true
SpaceAfterCStyleCast: true
SpaceAfterTemplateKeyword: true
SpaceBeforeAssignmentOperators: true
SpaceBeforeCpp11BracedList: false
SpaceBeforeCtorInitializerColon: true
SpaceBeforeInheritanceColon: true
SpaceBeforeParens: ControlStatements
SpaceBeforeRangeBasedForLoopColon: true
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 1
Standard: Cpp11
UseTab: Never
---
Language: ObjC
AccessModifierOffset: -1
AlignAfterOpenBracket: AlwaysBreak
AlignConsecutiveMacros: false
@@ -165,4 +107,3 @@ Standard: Latest
TabWidth: 8
UseCRLF: false
UseTab: Never
...

View File

@@ -47,10 +47,8 @@ static int __compareDoubles(const void* a, const void* b) {
return 0;
}
static void __printBenchmarkResult(
char* name,
clock_t start,
clock_t* endTimes) {
static void
__printBenchmarkResult(char* name, clock_t start, clock_t* endTimes) {
double timesInMs[NUM_REPETITIONS];
double mean = 0;
clock_t lastEnd = start;

View File

@@ -82,7 +82,9 @@ public:
return *this;
}
~ScopedGlobalRef() { reset(); }
~ScopedGlobalRef() {
reset();
}
/**
* Deletes the currently held reference and reassigns a new one to the
@@ -111,12 +113,16 @@ public:
/**
* Returns the underlying JNI global reference.
*/
T get() const { return mGlobalRef; }
T get() const {
return mGlobalRef;
}
/**
* Returns true if the underlying JNI reference is not NULL.
*/
operator bool() const { return mGlobalRef != NULL; }
operator bool() const {
return mGlobalRef != NULL;
}
ScopedGlobalRef(const ScopedGlobalRef& ref) = delete;
ScopedGlobalRef& operator=(const ScopedGlobalRef& other) = delete;

View File

@@ -81,7 +81,9 @@ public:
return *this;
}
~ScopedLocalRef() { reset(); }
~ScopedLocalRef() {
reset();
}
/**
* Deletes the currently held reference and reassigns a new one to the
@@ -110,12 +112,16 @@ public:
/**
* Returns the underlying JNI local reference.
*/
T get() const { return mLocalRef; }
T get() const {
return mLocalRef;
}
/**
* Returns true if the underlying JNI reference is not NULL.
*/
operator bool() const { return mLocalRef != NULL; }
operator bool() const {
return mLocalRef != NULL;
}
ScopedLocalRef(const ScopedLocalRef& ref) = delete;
ScopedLocalRef& operator=(const ScopedLocalRef& other) = delete;

View File

@@ -48,14 +48,18 @@ public:
YGNodeSetContext(node, context.asVoidPtr);
}
bool has(Edge edge) { return (edges_ & edge) == edge; }
bool has(Edge edge) {
return (edges_ & edge) == edge;
}
YGNodeEdges& add(Edge edge) {
edges_ |= edge;
return *this;
}
int get() { return edges_; }
int get() {
return edges_;
}
};
struct YogaValue {

View File

@@ -5,16 +5,16 @@
* LICENSE file in the root directory of this source tree.
*/
#include "jni.h"
#include "YGJNIVanilla.h"
#include <cstring>
#include "YGJNI.h"
#include "common.h"
#include "YGJTypesVanilla.h"
#include <iostream>
#include <memory>
#include "YogaJniException.h"
#include "LayoutContext.h"
#include "YGJNI.h"
#include "YGJTypesVanilla.h"
#include "YogaJniException.h"
#include "common.h"
#include "jni.h"
#include <yoga/Yoga-internal.h>
#include <yoga/bits/BitCast.h>
@@ -39,10 +39,8 @@ static jlong jni_YGConfigNewJNI(JNIEnv* /*env*/, jobject /*obj*/) {
return reinterpret_cast<jlong>(YGConfigNew());
}
static void jni_YGConfigFreeJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static void
jni_YGConfigFreeJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
const YGConfigRef config = _jlong2YGConfigRef(nativePointer);
// unique_ptr will destruct the underlying global_ref, if present.
auto context = std::unique_ptr<ScopedGlobalRef<jobject>>{
@@ -191,10 +189,8 @@ static void jni_YGConfigSetLoggerJNI(
}
}
static void jni_YGNodeDeallocateJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static void
jni_YGNodeDeallocateJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
if (nativePointer == 0) {
return;
}
@@ -202,10 +198,8 @@ static void jni_YGNodeDeallocateJNI(
YGNodeDeallocate(node);
}
static void jni_YGNodeResetJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static void
jni_YGNodeResetJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
const YGNodeRef node = _jlong2YGNodeRef(nativePointer);
void* context = YGNodeGetContext(node);
YGNodeReset(node);
@@ -269,10 +263,8 @@ static void jni_YGNodeRemoveChildJNI(
_jlong2YGNodeRef(nativePointer), _jlong2YGNodeRef(childPointer));
}
static void YGTransferLayoutOutputsRecursive(
JNIEnv* env,
jobject thiz,
YGNodeRef root) {
static void
YGTransferLayoutOutputsRecursive(JNIEnv* env, jobject thiz, YGNodeRef root) {
if (!YGNodeGetHasNewLayout(root)) {
return;
}
@@ -356,7 +348,6 @@ static void jni_YGNodeCalculateLayoutJNI(
jfloat height,
jlongArray nativePointers,
jobjectArray javaNodes) {
try {
PtrJNodeMapVanilla* layoutContext = nullptr;
auto map = PtrJNodeMapVanilla{};
@@ -389,10 +380,8 @@ static void jni_YGNodeCalculateLayoutJNI(
}
}
static void jni_YGNodeMarkDirtyJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static void
jni_YGNodeMarkDirtyJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
YGNodeMarkDirty(_jlong2YGNodeRef(nativePointer));
}
@@ -403,10 +392,8 @@ static void jni_YGNodeMarkDirtyAndPropagateToDescendantsJNI(
YGNodeMarkDirtyAndPropagateToDescendants(_jlong2YGNodeRef(nativePointer));
}
static jboolean jni_YGNodeIsDirtyJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static jboolean
jni_YGNodeIsDirtyJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
return (jboolean)YGNodeIsDirty(_jlong2YGNodeRef(nativePointer));
}
@@ -704,10 +691,8 @@ static void jni_YGNodeSetHasBaselineFuncJNI(
hasBaselineFunc ? YGJNIBaselineFunc : nullptr);
}
static void jni_YGNodePrintJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static void
jni_YGNodePrintJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
#ifdef DEBUG
const YGNodeRef node = _jlong2YGNodeRef(nativePointer);
YGNodePrint(
@@ -718,10 +703,8 @@ static void jni_YGNodePrintJNI(
#endif
}
static jlong jni_YGNodeCloneJNI(
JNIEnv* /*env*/,
jobject /*obj*/,
jlong nativePointer) {
static jlong
jni_YGNodeCloneJNI(JNIEnv* /*env*/, jobject /*obj*/, jlong nativePointer) {
auto node = _jlong2YGNodeRef(nativePointer);
const YGNodeRef clonedYogaNode = YGNodeClone(node);
YGNodeSetContext(clonedYogaNode, YGNodeGetContext(node));
@@ -928,9 +911,7 @@ static JNINativeMethod methods[] = {
{"jni_YGNodeStyleSetWidthAutoJNI",
"(J)V",
(void*)jni_YGNodeStyleSetWidthAutoJNI},
{"jni_YGNodeStyleGetHeightJNI",
"(J)J",
(void*) jni_YGNodeStyleGetHeightJNI},
{"jni_YGNodeStyleGetHeightJNI", "(J)J", (void*)jni_YGNodeStyleGetHeightJNI},
{"jni_YGNodeStyleSetHeightJNI",
"(JF)V",
(void*)jni_YGNodeStyleSetHeightJNI},

View File

@@ -5,9 +5,9 @@
* LICENSE file in the root directory of this source tree.
*/
#include "YogaJniException.h"
#include <stdexcept>
#include <string>
#include "YogaJniException.h"
#include "common.h"
namespace facebook::yoga::vanillajni {

View File

@@ -76,11 +76,8 @@ DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(void, Void) {
assertNoPendingJniException(env);
}
ScopedLocalRef<jobject> callStaticObjectMethod(
JNIEnv* env,
jclass clazz,
jmethodID methodId,
...) {
ScopedLocalRef<jobject>
callStaticObjectMethod(JNIEnv* env, jclass clazz, jmethodID methodId, ...) {
va_list args;
va_start(args, methodId);
jobject result = env->CallStaticObjectMethodV(clazz, methodId, args);

View File

@@ -59,11 +59,8 @@ DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(void, Void);
DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(jlong, Long);
DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(jfloat, Float);
ScopedLocalRef<jobject> callStaticObjectMethod(
JNIEnv* env,
jclass clazz,
jmethodID methodId,
...);
ScopedLocalRef<jobject>
callStaticObjectMethod(JNIEnv* env, jclass clazz, jmethodID methodId, ...);
/**
* Given a local or a global reference, this method creates a new global

View File

@@ -6,8 +6,8 @@
*/
#include "corefunctions.h"
#include "macros.h"
#include "YogaJniException.h"
#include "macros.h"
namespace facebook::yoga::vanillajni {

View File

@@ -10,7 +10,6 @@
#include <yoga/Yoga.h>
class Config {
friend class Node;
public:

View File

@@ -9,10 +9,10 @@
#include <yoga/Yoga.h>
#include "./Node.h"
#include "./Layout.h"
#include "./Size.h"
#include "./Config.h"
#include "./Layout.h"
#include "./Node.h"
#include "./Size.h"
static YGSize globalMeasureFunc(
YGNodeConstRef nodeRef,

View File

@@ -12,19 +12,16 @@
#include <emscripten/bind.h>
#include <yoga/Yoga.h>
#include "./Config.h"
#include "./Layout.h"
#include "./Size.h"
#include "./Value.h"
#include "./Config.h"
class MeasureCallback {
public:
virtual ~MeasureCallback() {}
virtual Size measure(
float width,
int widthMode,
float height,
int heightMode) = 0;
virtual Size
measure(float width, int widthMode, float height, int heightMode) = 0;
};
class MeasureCallbackWrapper : public emscripten::wrapper<MeasureCallback> {
@@ -44,11 +41,12 @@ public:
class DirtiedCallbackWrapper : public emscripten::wrapper<DirtiedCallback> {
public:
EMSCRIPTEN_WRAPPER(DirtiedCallbackWrapper);
void dirtied() { return call<void>("dirtied"); }
void dirtied() {
return call<void>("dirtied");
}
};
class Node {
public:
static Node* createDefault(void);
static Node* createWithConfig(Config* config);

View File

@@ -5,14 +5,14 @@
* LICENSE file in the root directory of this source tree.
*/
#include "./Node.h"
#include "./Config.h"
#include "./Layout.h"
#include "./Node.h"
#include "./Size.h"
#include "./Value.h"
#include "./Config.h"
#include <yoga/Yoga.h>
#include <emscripten/bind.h>
#include <yoga/Yoga.h>
using namespace emscripten;

View File

@@ -7,8 +7,8 @@
#define YOGA_COMPACT_VALUE_TEST
#include <yoga/style/CompactValue.h>
#include <gtest/gtest.h>
#include <yoga/style/CompactValue.h>
#include <cmath>
using facebook::yoga::CompactValue;

View File

@@ -6,9 +6,9 @@
*/
#include <gtest/gtest.h>
#include <yoga/event/event.h>
#include <yoga/Yoga.h>
#include <yoga/YGEnums.h>
#include <yoga/Yoga.h>
#include <yoga/event/event.h>
#include <algorithm>
#include <functional>
@@ -50,7 +50,9 @@ class EventTest : public ::testing::Test {
public:
static std::vector<EventArgs> events;
static EventArgs& lastEvent() { return events.back(); }
static EventArgs& lastEvent() {
return events.back();
}
void TearDown() override;
};

View File

@@ -7,9 +7,9 @@
#include <gtest/gtest.h>
#include <yoga/YGValue.h>
#include <yoga/numeric/Comparison.h>
#include <yoga/numeric/FloatOptional.h>
#include <yoga/YGValue.h>
using namespace facebook;
using namespace facebook::yoga;

View File

@@ -7,8 +7,8 @@
#include <gtest/gtest.h>
#include <cstdint>
#include <yoga/bits/NumericBitfield.h>
#include <cstdint>
namespace facebook::yoga {

View File

@@ -8,10 +8,8 @@
#include <gtest/gtest.h>
#include <yoga/Yoga.h>
static float _baseline(
YGNodeConstRef node,
const float /*width*/,
const float /*height*/) {
static float
_baseline(YGNodeConstRef node, const float /*width*/, const float /*height*/) {
float* baseline = (float*)YGNodeGetContext(node);
return *baseline;
}

View File

@@ -645,7 +645,6 @@ static YGSize _measure_90_10(
YGMeasureMode /*widthMode*/,
float /*height*/,
YGMeasureMode /*heightMode*/) {
return YGSize{90, 10};
}
@@ -655,7 +654,6 @@ static YGSize _measure_100_100(
YGMeasureMode /*widthMode*/,
float /*height*/,
YGMeasureMode /*heightMode*/) {
return YGSize{100, 100};
}

View File

@@ -6,8 +6,8 @@
*/
#include <gtest/gtest.h>
#include <yoga/Yoga.h>
#include <yoga/Yoga-internal.h>
#include <yoga/Yoga.h>
TEST(YogaTest, rounding_value) {
// Test that whole numbers are rounded to whole despite ceil/floor flags

View File

@@ -5,11 +5,11 @@
* LICENSE file in the root directory of this source tree.
*/
#include <cstdint>
#include <type_traits>
#include <gtest/gtest.h>
#include <yoga/Yoga.h>
#include <yoga/style/Style.h>
#include <cstdint>
#include <type_traits>
#define ACCESSOR_TESTS_1(NAME, X) \
style.NAME() = X; \

View File

@@ -7,8 +7,8 @@
#include "TestUtil.h"
#include <yoga/node/Node.h>
#include <yoga/event/event.h>
#include <yoga/node/Node.h>
namespace facebook::yoga::test {
@@ -20,7 +20,6 @@ void yogaEventSubscriber(
YGNodeConstRef /*node*/,
Event::Type eventType,
const Event::Data& /*eventData*/) {
switch (eventType) {
case Event::NodeAllocation:
nodeInstanceCount++;

View File

@@ -5,8 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/
#include <yoga/Yoga.h>
#include <yoga/Yoga-internal.h>
#include <yoga/Yoga.h>
#include <yoga/algorithm/Cache.h>
#include <yoga/algorithm/CalculateLayout.h>

View File

@@ -71,10 +71,8 @@ YG_EXPORT YGNodeRef YGNodeGetChild(YGNodeRef node, size_t index);
YG_EXPORT YGNodeRef YGNodeGetOwner(YGNodeRef node);
YG_EXPORT YGNodeRef YGNodeGetParent(YGNodeRef node);
YG_EXPORT size_t YGNodeGetChildCount(YGNodeConstRef node);
YG_EXPORT void YGNodeSetChildren(
YGNodeRef owner,
const YGNodeRef* children,
size_t count);
YG_EXPORT void
YGNodeSetChildren(YGNodeRef owner, const YGNodeRef* children, size_t count);
YG_EXPORT void YGNodeSetIsReferenceBaseline(
YGNodeRef node,
@@ -197,41 +195,29 @@ YG_EXPORT void YGNodeStyleSetFlexBasisPercent(YGNodeRef node, float flexBasis);
YG_EXPORT void YGNodeStyleSetFlexBasisAuto(YGNodeRef node);
YG_EXPORT YGValue YGNodeStyleGetFlexBasis(YGNodeConstRef node);
YG_EXPORT void YGNodeStyleSetPosition(
YGNodeRef node,
YGEdge edge,
float position);
YG_EXPORT void YGNodeStyleSetPositionPercent(
YGNodeRef node,
YGEdge edge,
float position);
YG_EXPORT void
YGNodeStyleSetPosition(YGNodeRef node, YGEdge edge, float position);
YG_EXPORT void
YGNodeStyleSetPositionPercent(YGNodeRef node, YGEdge edge, float position);
YG_EXPORT YGValue YGNodeStyleGetPosition(YGNodeConstRef node, YGEdge edge);
YG_EXPORT void YGNodeStyleSetMargin(YGNodeRef node, YGEdge edge, float margin);
YG_EXPORT void YGNodeStyleSetMarginPercent(
YGNodeRef node,
YGEdge edge,
float margin);
YG_EXPORT void
YGNodeStyleSetMarginPercent(YGNodeRef node, YGEdge edge, float margin);
YG_EXPORT void YGNodeStyleSetMarginAuto(YGNodeRef node, YGEdge edge);
YG_EXPORT YGValue YGNodeStyleGetMargin(YGNodeConstRef node, YGEdge edge);
YG_EXPORT void YGNodeStyleSetPadding(
YGNodeRef node,
YGEdge edge,
float padding);
YG_EXPORT void YGNodeStyleSetPaddingPercent(
YGNodeRef node,
YGEdge edge,
float padding);
YG_EXPORT void
YGNodeStyleSetPadding(YGNodeRef node, YGEdge edge, float padding);
YG_EXPORT void
YGNodeStyleSetPaddingPercent(YGNodeRef node, YGEdge edge, float padding);
YG_EXPORT YGValue YGNodeStyleGetPadding(YGNodeConstRef node, YGEdge edge);
YG_EXPORT void YGNodeStyleSetBorder(YGNodeRef node, YGEdge edge, float border);
YG_EXPORT float YGNodeStyleGetBorder(YGNodeConstRef node, YGEdge edge);
YG_EXPORT void YGNodeStyleSetGap(
YGNodeRef node,
YGGutter gutter,
float gapLength);
YG_EXPORT void
YGNodeStyleSetGap(YGNodeRef node, YGGutter gutter, float gapLength);
YG_EXPORT float YGNodeStyleGetGap(YGNodeConstRef node, YGGutter gutter);
YG_EXPORT void YGNodeStyleSetWidth(YGNodeRef node, float width);

View File

@@ -16,7 +16,6 @@ namespace facebook::yoga {
float calculateBaseline(const yoga::Node* node) {
if (node->hasBaselineFunc()) {
Event::publish<Event::NodeBaselineStart>(node);
const float baseline = node->baseline(

View File

@@ -2603,7 +2603,6 @@ bool calculateLayoutInternal(
layout->lastOwnerDirection = ownerDirection;
if (cachedResults == nullptr) {
layoutMarkerData.maxMeasureCache = std::max(
layoutMarkerData.maxMeasureCache,
layout->nextCachedMeasurementsIndex + 1u);

View File

@@ -7,8 +7,8 @@
#pragma once
#include <bitset>
#include <yoga/YGEnums.h>
#include <bitset>
namespace facebook::yoga {

View File

@@ -8,8 +8,8 @@
#pragma once
#include <bitset>
#include <cstdio>
#include <cstdint>
#include <cstdio>
#include <yoga/YGEnums.h>

View File

@@ -69,10 +69,8 @@ public:
va_list args) const;
void setCloneNodeCallback(YGCloneNodeFunc cloneNode);
YGNodeRef cloneNode(
YGNodeConstRef node,
YGNodeConstRef owner,
size_t childIndex) const;
YGNodeRef
cloneNode(YGNodeConstRef node, YGNodeConstRef owner, size_t childIndex) const;
static const Config& getDefault();

View File

@@ -8,8 +8,8 @@
#pragma once
#include <yoga/Yoga.h>
#include <yoga/node/Node.h>
#include <yoga/config/Config.h>
#include <yoga/node/Node.h>
namespace facebook::yoga {

View File

@@ -10,8 +10,8 @@
#include <yoga/Yoga.h>
#include <yoga/YGEnums.h>
#include <yoga/node/Node.h>
#include <yoga/config/Config.h>
#include <yoga/node/Node.h>
namespace facebook::yoga {

View File

@@ -9,10 +9,10 @@
#include <yoga/Yoga.h>
#include <stdint.h>
#include <array>
#include <functional>
#include <vector>
#include <array>
#include <stdint.h>
namespace facebook::yoga {

View File

@@ -10,8 +10,8 @@
#include <array>
#include <yoga/bits/NumericBitfield.h>
#include <yoga/numeric/FloatOptional.h>
#include <yoga/node/CachedMeasurement.h>
#include <yoga/numeric/FloatOptional.h>
namespace facebook::yoga {
@@ -60,11 +60,17 @@ public:
flags_.direction = static_cast<uint32_t>(direction) & 0x03;
}
bool hadOverflow() const { return flags_.hadOverflow; }
void setHadOverflow(bool hadOverflow) { flags_.hadOverflow = hadOverflow; }
bool hadOverflow() const {
return flags_.hadOverflow;
}
void setHadOverflow(bool hadOverflow) {
flags_.hadOverflow = hadOverflow;
}
bool operator==(LayoutResults layout) const;
bool operator!=(LayoutResults layout) const { return !(*this == layout); }
bool operator!=(LayoutResults layout) const {
return !(*this == layout);
}
};
} // namespace facebook::yoga

View File

@@ -7,8 +7,8 @@
#pragma once
#include <cstdint>
#include <stdio.h>
#include <cstdint>
#include <vector>
#include <yoga/Yoga.h>
@@ -82,60 +82,98 @@ public:
Node& operator=(const Node&) = delete;
// Getters
void* getContext() const { return context_; }
void* getContext() const {
return context_;
}
void print();
bool getHasNewLayout() const { return flags_.hasNewLayout; }
bool getHasNewLayout() const {
return flags_.hasNewLayout;
}
YGNodeType getNodeType() const {
return static_cast<YGNodeType>(flags_.nodeType);
}
bool hasMeasureFunc() const noexcept { return measureFunc_ != nullptr; }
bool hasMeasureFunc() const noexcept {
return measureFunc_ != nullptr;
}
YGSize measure(float, YGMeasureMode, float, YGMeasureMode);
bool hasBaselineFunc() const noexcept { return baselineFunc_ != nullptr; }
bool hasBaselineFunc() const noexcept {
return baselineFunc_ != nullptr;
}
float baseline(float width, float height) const;
bool hasErrata(YGErrata errata) const { return config_->hasErrata(errata); }
bool hasErrata(YGErrata errata) const {
return config_->hasErrata(errata);
}
YGDirtiedFunc getDirtiedFunc() const { return dirtiedFunc_; }
YGDirtiedFunc getDirtiedFunc() const {
return dirtiedFunc_;
}
// For Performance reasons passing as reference.
Style& getStyle() { return style_; }
Style& getStyle() {
return style_;
}
const Style& getStyle() const { return style_; }
const Style& getStyle() const {
return style_;
}
// For Performance reasons passing as reference.
LayoutResults& getLayout() { return layout_; }
LayoutResults& getLayout() {
return layout_;
}
const LayoutResults& getLayout() const { return layout_; }
const LayoutResults& getLayout() const {
return layout_;
}
size_t getLineIndex() const { return lineIndex_; }
size_t getLineIndex() const {
return lineIndex_;
}
bool isReferenceBaseline() const { return flags_.isReferenceBaseline; }
bool isReferenceBaseline() const {
return flags_.isReferenceBaseline;
}
// returns the Node that owns this Node. An owner is used to identify
// the YogaTree that a Node belongs to. This method will return the parent
// of the Node when a Node only belongs to one YogaTree or nullptr when
// the Node is shared between two or more YogaTrees.
Node* getOwner() const { return owner_; }
Node* getOwner() const {
return owner_;
}
// Deprecated, use getOwner() instead.
Node* getParent() const { return getOwner(); }
Node* getParent() const {
return getOwner();
}
const std::vector<Node*>& getChildren() const { return children_; }
const std::vector<Node*>& getChildren() const {
return children_;
}
Node* getChild(size_t index) const { return children_.at(index); }
Node* getChild(size_t index) const {
return children_.at(index);
}
size_t getChildCount() const { return children_.size(); }
size_t getChildCount() const {
return children_.size();
}
const Config* getConfig() const { return config_; }
const Config* getConfig() const {
return config_;
}
bool isDirty() const { return flags_.isDirty; }
bool isDirty() const {
return flags_.isDirty;
}
std::array<YGValue, 2> getResolvedDimensions() const {
return resolvedDimensions_;
@@ -200,9 +238,13 @@ public:
const;
// Setters
void setContext(void* context) { context_ = context; }
void setContext(void* context) {
context_ = context;
}
void setPrintFunc(YGPrintFunc printFunc) { printFunc_ = printFunc; }
void setPrintFunc(YGPrintFunc printFunc) {
printFunc_ = printFunc;
}
void setHasNewLayout(bool hasNewLayout) {
flags_.hasNewLayout = hasNewLayout;
@@ -218,21 +260,33 @@ public:
baselineFunc_ = baseLineFunc;
}
void setDirtiedFunc(YGDirtiedFunc dirtiedFunc) { dirtiedFunc_ = dirtiedFunc; }
void setDirtiedFunc(YGDirtiedFunc dirtiedFunc) {
dirtiedFunc_ = dirtiedFunc;
}
void setStyle(const Style& style) { style_ = style; }
void setStyle(const Style& style) {
style_ = style;
}
void setLayout(const LayoutResults& layout) { layout_ = layout; }
void setLayout(const LayoutResults& layout) {
layout_ = layout;
}
void setLineIndex(size_t lineIndex) { lineIndex_ = lineIndex; }
void setLineIndex(size_t lineIndex) {
lineIndex_ = lineIndex;
}
void setIsReferenceBaseline(bool isReferenceBaseline) {
flags_.isReferenceBaseline = isReferenceBaseline;
}
void setOwner(Node* owner) { owner_ = owner; }
void setOwner(Node* owner) {
owner_ = owner;
}
void setChildren(const std::vector<Node*>& children) { children_ = children; }
void setChildren(const std::vector<Node*>& children) {
children_ = children;
}
// TODO: rvalue override for setChildren

View File

@@ -21,9 +21,13 @@ public:
constexpr FloatOptional() = default;
// returns the wrapped value, or a value x with YGIsUndefined(x) == true
constexpr float unwrap() const { return value_; }
constexpr float unwrap() const {
return value_;
}
bool isUndefined() const { return std::isnan(value_); }
bool isUndefined() const {
return std::isnan(value_);
}
};
// operators take FloatOptional by value, as it is a 32bit value

View File

@@ -136,7 +136,9 @@ public:
repr_ != ZERO_BITS_PERCENT && std::isnan(yoga::bit_cast<float>(repr_)));
}
bool isAuto() const noexcept { return repr_ == AUTO_BITS; }
bool isAuto() const noexcept {
return repr_ == AUTO_BITS;
}
private:
uint32_t repr_;
@@ -152,7 +154,9 @@ private:
constexpr CompactValue(uint32_t data) noexcept : repr_(data) {}
VISIBLE_FOR_TESTING uint32_t repr() { return repr_; }
VISIBLE_FOR_TESTING uint32_t repr() {
return repr_;
}
};
template <>

View File

@@ -5,8 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/
#include <yoga/style/Style.h>
#include <yoga/numeric/Comparison.h>
#include <yoga/style/Style.h>
namespace facebook::yoga {

View File

@@ -37,7 +37,9 @@ public:
struct BitfieldRef {
Style& style;
uint8_t offset;
operator T() const { return getEnumData<T>(style.flags, offset); }
operator T() const {
return getEnumData<T>(style.flags, offset);
}
BitfieldRef<T>& operator=(T x) {
setEnumData<T>(style.flags, offset, x);
return *this;
@@ -47,7 +49,9 @@ public:
template <typename T, T Style::*Prop>
struct Ref {
Style& style;
operator T() const { return style.*Prop; }
operator T() const {
return style.*Prop;
}
Ref<T, Prop>& operator=(T value) {
style.*Prop = value;
return *this;
@@ -59,8 +63,12 @@ public:
struct Ref {
Style& style;
Idx idx;
operator CompactValue() const { return (style.*Prop)[idx]; }
operator YGValue() const { return (style.*Prop)[idx]; }
operator CompactValue() const {
return (style.*Prop)[idx];
}
operator YGValue() const {
return (style.*Prop)[idx];
}
Ref& operator=(CompactValue value) {
(style.*Prop)[idx] = value;
return *this;
@@ -72,9 +80,15 @@ public:
style.*Prop = values;
return *this;
}
operator const Values<Idx>&() const { return style.*Prop; }
Ref operator[](Idx idx) { return {style, idx}; }
CompactValue operator[](Idx idx) const { return (style.*Prop)[idx]; }
operator const Values<Idx>&() const {
return style.*Prop;
}
Ref operator[](Idx idx) {
return {style, idx};
}
CompactValue operator[](Idx idx) const {
return (style.*Prop)[idx];
}
};
Style() {
@@ -128,7 +142,9 @@ public:
YGDirection direction() const {
return getEnumData<YGDirection>(flags, directionOffset);
}
BitfieldRef<YGDirection> direction() { return {*this, directionOffset}; }
BitfieldRef<YGDirection> direction() {
return {*this, directionOffset};
}
YGFlexDirection flexDirection() const {
return getEnumData<YGFlexDirection>(flags, flexdirectionOffset);
@@ -147,17 +163,23 @@ public:
YGAlign alignContent() const {
return getEnumData<YGAlign>(flags, alignContentOffset);
}
BitfieldRef<YGAlign> alignContent() { return {*this, alignContentOffset}; }
BitfieldRef<YGAlign> alignContent() {
return {*this, alignContentOffset};
}
YGAlign alignItems() const {
return getEnumData<YGAlign>(flags, alignItemsOffset);
}
BitfieldRef<YGAlign> alignItems() { return {*this, alignItemsOffset}; }
BitfieldRef<YGAlign> alignItems() {
return {*this, alignItemsOffset};
}
YGAlign alignSelf() const {
return getEnumData<YGAlign>(flags, alignSelfOffset);
}
BitfieldRef<YGAlign> alignSelf() { return {*this, alignSelfOffset}; }
BitfieldRef<YGAlign> alignSelf() {
return {*this, alignSelfOffset};
}
YGPositionType positionType() const {
return getEnumData<YGPositionType>(flags, positionTypeOffset);
@@ -166,62 +188,118 @@ public:
return {*this, positionTypeOffset};
}
YGWrap flexWrap() const { return getEnumData<YGWrap>(flags, flexWrapOffset); }
BitfieldRef<YGWrap> flexWrap() { return {*this, flexWrapOffset}; }
YGWrap flexWrap() const {
return getEnumData<YGWrap>(flags, flexWrapOffset);
}
BitfieldRef<YGWrap> flexWrap() {
return {*this, flexWrapOffset};
}
YGOverflow overflow() const {
return getEnumData<YGOverflow>(flags, overflowOffset);
}
BitfieldRef<YGOverflow> overflow() { return {*this, overflowOffset}; }
BitfieldRef<YGOverflow> overflow() {
return {*this, overflowOffset};
}
YGDisplay display() const {
return getEnumData<YGDisplay>(flags, displayOffset);
}
BitfieldRef<YGDisplay> display() { return {*this, displayOffset}; }
BitfieldRef<YGDisplay> display() {
return {*this, displayOffset};
}
FloatOptional flex() const { return flex_; }
Ref<FloatOptional, &Style::flex_> flex() { return {*this}; }
FloatOptional flex() const {
return flex_;
}
Ref<FloatOptional, &Style::flex_> flex() {
return {*this};
}
FloatOptional flexGrow() const { return flexGrow_; }
Ref<FloatOptional, &Style::flexGrow_> flexGrow() { return {*this}; }
FloatOptional flexGrow() const {
return flexGrow_;
}
Ref<FloatOptional, &Style::flexGrow_> flexGrow() {
return {*this};
}
FloatOptional flexShrink() const { return flexShrink_; }
Ref<FloatOptional, &Style::flexShrink_> flexShrink() { return {*this}; }
FloatOptional flexShrink() const {
return flexShrink_;
}
Ref<FloatOptional, &Style::flexShrink_> flexShrink() {
return {*this};
}
CompactValue flexBasis() const { return flexBasis_; }
Ref<CompactValue, &Style::flexBasis_> flexBasis() { return {*this}; }
CompactValue flexBasis() const {
return flexBasis_;
}
Ref<CompactValue, &Style::flexBasis_> flexBasis() {
return {*this};
}
const Edges& margin() const { return margin_; }
IdxRef<YGEdge, &Style::margin_> margin() { return {*this}; }
const Edges& margin() const {
return margin_;
}
IdxRef<YGEdge, &Style::margin_> margin() {
return {*this};
}
const Edges& position() const { return position_; }
IdxRef<YGEdge, &Style::position_> position() { return {*this}; }
const Edges& position() const {
return position_;
}
IdxRef<YGEdge, &Style::position_> position() {
return {*this};
}
const Edges& padding() const { return padding_; }
IdxRef<YGEdge, &Style::padding_> padding() { return {*this}; }
const Edges& padding() const {
return padding_;
}
IdxRef<YGEdge, &Style::padding_> padding() {
return {*this};
}
const Edges& border() const { return border_; }
IdxRef<YGEdge, &Style::border_> border() { return {*this}; }
const Edges& border() const {
return border_;
}
IdxRef<YGEdge, &Style::border_> border() {
return {*this};
}
const Gutters& gap() const { return gap_; }
IdxRef<YGGutter, &Style::gap_> gap() { return {*this}; }
const Gutters& gap() const {
return gap_;
}
IdxRef<YGGutter, &Style::gap_> gap() {
return {*this};
}
const Dimensions& dimensions() const { return dimensions_; }
IdxRef<YGDimension, &Style::dimensions_> dimensions() { return {*this}; }
const Dimensions& dimensions() const {
return dimensions_;
}
IdxRef<YGDimension, &Style::dimensions_> dimensions() {
return {*this};
}
const Dimensions& minDimensions() const { return minDimensions_; }
const Dimensions& minDimensions() const {
return minDimensions_;
}
IdxRef<YGDimension, &Style::minDimensions_> minDimensions() {
return {*this};
}
const Dimensions& maxDimensions() const { return maxDimensions_; }
const Dimensions& maxDimensions() const {
return maxDimensions_;
}
IdxRef<YGDimension, &Style::maxDimensions_> maxDimensions() {
return {*this};
}
// Yoga specific properties, not compatible with flexbox specification
FloatOptional aspectRatio() const { return aspectRatio_; }
Ref<FloatOptional, &Style::aspectRatio_> aspectRatio() { return {*this}; }
FloatOptional aspectRatio() const {
return aspectRatio_;
}
Ref<FloatOptional, &Style::aspectRatio_> aspectRatio() {
return {*this};
}
};
YG_EXPORT bool operator==(const Style& lhs, const Style& rhs);