DaddyFrosty/yoga

Fork 0

Commit Graph

Author	SHA1	Message	Date
Dustin Shahidehpour	e00e30ca15	Only mark Nodes dirty if an actual node is removed. Summary: Currently, when we try to remove a child from a node, that node is mark dirty //regardless of whether or not anything was actually removed//. This fixes it. Reviewed By: gkassabli Differential Revision: D4125453 fbshipit-source-id: 745cfc55269415fea106a80c72401eb3074f2d31	2016-11-03 13:38:05 -07:00
Emil Sjolander	1f300a58fb	Free memory used in tests to enable use of valgrind Summary: Its very usefull to be able to run valgrind on the tests and benchmarks. We were previously not freeing test memory so valgrind output was very messy. Reviewed By: javache Differential Revision: D3937493 fbshipit-source-id: 23c6970d7769b081575d39de583ba954fc65a397	2016-09-29 04:22:47 -07:00
Emil Sjolander	36eaae88e0	Add tests for dirty propagation Summary: Previous test for dirty propagation (last test in CSSLayoutTest.cpp) only tested one specific case. This tests much more of the bahavior to ensure that a vital optimization in css-layout is applied correctly. Reviewed By: lucasr Differential Revision: D3790968 fbshipit-source-id: af11a5924640cd1d497920cd97549603a9f147cc	2016-08-31 08:07:59 -07:00

Author

SHA1

Message

Date

Dustin Shahidehpour

e00e30ca15

Only mark Nodes dirty if an actual node is removed.

Summary: Currently, when we try to remove a child from a node, that node is mark dirty //regardless of whether or not anything was actually removed//. This fixes it.

Reviewed By: gkassabli

Differential Revision: D4125453

fbshipit-source-id: 745cfc55269415fea106a80c72401eb3074f2d31

2016-11-03 13:38:05 -07:00

Emil Sjolander

1f300a58fb

Free memory used in tests to enable use of valgrind

Summary: Its very usefull to be able to run valgrind on the tests and benchmarks. We were previously not freeing test memory so valgrind output was very messy.

Reviewed By: javache

Differential Revision: D3937493

fbshipit-source-id: 23c6970d7769b081575d39de583ba954fc65a397

2016-09-29 04:22:47 -07:00

Emil Sjolander

36eaae88e0

Add tests for dirty propagation

Summary: Previous test for dirty propagation (last test in CSSLayoutTest.cpp) only tested one specific case. This tests much more of the bahavior to ensure that a vital optimization in css-layout is applied correctly.

Reviewed By: lucasr

Differential Revision: D3790968

fbshipit-source-id: af11a5924640cd1d497920cd97549603a9f147cc

2016-08-31 08:07:59 -07:00

3 Commits