DaddyFrosty/yoga

Fork 0

Commit Graph

Author	SHA1	Message	Date
Nick Gerleman	c51d7d82a6	Consolidate JavaScript Flavors Fixes https://github.com/facebook/yoga/issues/1417 This dramatically simplifies the matrix of Node vs web, ASM vs WASM, sync vs async compilation, or CommonJS vs ES Modules. We have one variant, using without, with ESModule top-level await to do async compilation. Web/node share the same binary, and we base64 encode the WASM into a wrapper JS file for compatibility with Node and bundlers. After this change we target: This has some downsides, like requiring an environment with top level await, but also has upsides, like a consistent, sync looking API compatible with older Yoga, and mitigating TypeScript issues with package exports and typings resolution. ## Test Plan 1. `yarn test` 2. `yarn lint` 3. `yarn tsc` 4. `yarn build` website-next 5. Locally test website 5. Examine package artifact created by GitHub	2023-10-19 04:59:10 -07:00
Joe Vilches	b558059b74	Revamp tests for row reverse + border after fix Summary: this is fixed now so we can turn it on Reviewed By: NickGerleman Differential Revision: D50348206 fbshipit-source-id: 61c2a72164c6f0ee91b1b5b576d3f129e8cfbe40	2023-10-17 20:30:16 -07:00
Eric Rozell	50ecd98141	Add test fixture to reproduce bug in aspect-ratio (#1421 ) Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1421 Adds repro of inconsistent implementation of aspect-ratio behavior across Web and React Native. Reviewed By: NickGerleman Differential Revision: D50225804 fbshipit-source-id: 0494e0373dcdebc789715b2ec19c002a47d69ce0	2023-10-12 15:02:00 -07:00

Author

SHA1

Message

Date

Nick Gerleman

c51d7d82a6

Consolidate JavaScript Flavors

Fixes https://github.com/facebook/yoga/issues/1417

This dramatically simplifies the matrix of Node vs web, ASM vs WASM, sync vs async compilation, or CommonJS vs ES Modules. We have one variant, using without, with ESModule top-level await to do async compilation. Web/node share the same binary, and we base64 encode the WASM into a wrapper JS file for compatibility with Node and bundlers.

After this change we target:

This has some downsides, like requiring an environment with top level await, but also has upsides, like a consistent, sync looking API compatible with older Yoga, and mitigating TypeScript issues with package exports and typings resolution.

## Test Plan
1. `yarn test`
2. `yarn lint`
3. `yarn tsc`
4. `yarn build` website-next
5. Locally test website
5. Examine package artifact created by GitHub

2023-10-19 04:59:10 -07:00

Joe Vilches

b558059b74

Revamp tests for row reverse + border after fix

Summary: this is fixed now so we can turn it on

Reviewed By: NickGerleman

Differential Revision: D50348206

fbshipit-source-id: 61c2a72164c6f0ee91b1b5b576d3f129e8cfbe40

2023-10-17 20:30:16 -07:00

Eric Rozell

50ecd98141

Add test fixture to reproduce bug in aspect-ratio (#1421 )

Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1421

Adds repro of inconsistent implementation of aspect-ratio behavior across Web and React Native.

Reviewed By: NickGerleman

Differential Revision: D50225804

fbshipit-source-id: 0494e0373dcdebc789715b2ec19c002a47d69ce0

2023-10-12 15:02:00 -07:00

3 Commits