DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Use isnan(3) to check for NaN #1

Merged
swolchok merged 2 commits from master into master 2014-04-18 14:06:25 -07:00
Conversation 3 Commits 2 Files Changed 1 +3 -2
swolchok commented 2014-04-18 13:42:45 -07:00 (Migrated from github.com)
Copy Link

There's a standard C function (actually a macro) to check for NaN; let's use that for clarity.

There's a standard C function (actually a macro) to check for NaN; let's use that for clarity.
swolchok commented 2014-04-18 13:47:28 -07:00 (Migrated from github.com)
Copy Link

Also pushed 5498516 which fixes a memory leak

Also pushed 5498516 which fixes a memory leak
swolchok commented 2014-04-18 13:52:27 -07:00 (Migrated from github.com)
Copy Link

btw to find the bug fixed by 5498516:
brew install valgrind
clang Layout.c
valgrind ./a.out
note complaint about "definitely lost" bytes, follow advice to re-run with --leak-check=full:
valgrind --leak-check=full ./a.out

btw to find the bug fixed by 5498516: brew install valgrind clang Layout.c valgrind ./a.out note complaint about "definitely lost" bytes, follow advice to re-run with --leak-check=full: valgrind --leak-check=full ./a.out
vjeux commented 2014-04-18 14:06:37 -07:00 (Migrated from github.com)
Copy Link

Thanks! I definitively need to install valgrind :)

Thanks! I definitively need to install valgrind :)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?