DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Migrate CI from TravisCI to GitHub Actions #1004

Closed
bigfootjon wants to merge 8 commits from gh-actions into master
pull from: gh-actions
merge into: DaddyFrosty:master
Conversation 9 Commits 8 Files Changed 3 +62 -83
bigfootjon commented 2020-05-06 11:45:00 -07:00 (Migrated from github.com)
Copy Link

Migrate from TravisCI to GitHub Actions. Facebook employees can read about this migration here.

CC: @wittgenst

Test Plan:
GitHub Actions CI

Migrate from TravisCI to GitHub Actions. Facebook employees can read about this migration [here](https://fburl.com/rfp033ou). CC: @wittgenst Test Plan: GitHub Actions CI
facebook-github-bot (Migrated from github.com) reviewed 2020-05-06 11:45:26 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://www.internalfb.com/intern/diff/D21431309/).
zpao (Migrated from github.com) reviewed 2020-05-06 14:45:35 -07:00
.github/workflows/ci.yml
@@ -0,0 +1,56 @@
name: CI
zpao (Migrated from github.com) commented 2020-05-06 14:35:11 -07:00
Copy Link

We should come up with some best practice here… I almost prefer website deployment being a completely different workflow that only runs on master (so it's obvious at the workflow configuration when it runs, not needing to read this far to find out)

We should come up with some best practice here… I almost prefer website deployment being a completely different workflow that only runs on master (so it's obvious at the workflow configuration when it runs, not needing to read this far to find out)
zpao (Migrated from github.com) commented 2020-05-06 14:38:17 -07:00
Copy Link

There's no matrix so this is a no-op I believe

There's no matrix so this is a no-op I believe
.github/workflows/ci.yml
@@ -0,0 +10,4 @@
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 8.x
zpao (Migrated from github.com) commented 2020-05-06 14:39:41 -07:00
Copy Link

AHHHH Node 8 EOL was last year. Let's at least use 10 (or 12)

AHHHH Node 8 EOL was last year. Let's at least use 10 (or 12)
.github/workflows/ci.yml
@@ -0,0 +25,4 @@
publish_branch: gh-pages
publish_dir: website/public
cname: yogalayout.com
keep_files: true
zpao (Migrated from github.com) commented 2020-05-06 14:41:00 -07:00
Copy Link

Why?

Why?
.github/workflows/ci.yml
@@ -0,0 +42,4 @@
pushd $HOME
git clone --depth 1 https://github.com/facebook/buck.git
cd buck
ant
zpao (Migrated from github.com) commented 2020-05-06 14:45:27 -07:00
Copy Link

Oh geez this is building Buck on every change… that's… wow. We probably actually need to do something different here since Buck master is diverging (but let's ignore that for now)

Oh geez this is building Buck on every change… that's… wow. We probably actually need to do something different here since Buck master is diverging (but let's ignore that for now)
bigfootjon (Migrated from github.com) reviewed 2020-05-06 15:26:18 -07:00
.github/workflows/ci.yml
@@ -0,0 +10,4 @@
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 8.x
bigfootjon (Migrated from github.com) commented 2020-05-06 15:26:17 -07:00
Copy Link

I just copied the Travis job ¯\_(ツ)_/¯

When I tried upgrading to a more recent version of node it broke the yarn build step :(

I just copied the Travis job ¯\\\_(ツ)\_/¯ When I tried upgrading to a more recent version of node it broke the `yarn build` step :(
bigfootjon (Migrated from github.com) reviewed 2020-05-06 15:28:10 -07:00
.github/workflows/ci.yml
@@ -0,0 +1,56 @@
name: CI
bigfootjon (Migrated from github.com) commented 2020-05-06 15:28:10 -07:00
Copy Link

I was trying to avoid writing it out twice, because for PRs it would be nice to know if the website build is broken. I'd have to copy the entire job and any changes to the build process would need to be done in two places.

I was trying to avoid writing it out twice, because for PRs it would be nice to know if the website build is broken. I'd have to copy the entire job and any changes to the build process would need to be done in two places.
bigfootjon (Migrated from github.com) reviewed 2020-05-06 15:29:40 -07:00
.github/workflows/ci.yml
@@ -0,0 +25,4 @@
publish_branch: gh-pages
publish_dir: website/public
cname: yogalayout.com
keep_files: true
bigfootjon (Migrated from github.com) commented 2020-05-06 15:29:40 -07:00
Copy Link

It was in .travis.yml: skip-cleanup: true

Ref:
https://docs.travis-ci.com/user/deployment/pages/
https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-keeping-existing-files

It was in `.travis.yml`: `skip-cleanup: true` Ref: https://docs.travis-ci.com/user/deployment/pages/ https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-keeping-existing-files
facebook-github-bot (Migrated from github.com) reviewed 2020-05-06 15:34:36 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://www.internalfb.com/intern/diff/D21431309/).
facebook-github-bot (Migrated from github.com) reviewed 2020-05-06 16:49:00 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://www.internalfb.com/intern/diff/D21431309/).
facebook-github-bot (Migrated from github.com) reviewed 2020-05-07 10:11:51 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bigfootjon has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://www.internalfb.com/intern/diff/D21431309/).
facebook-github-bot commented 2020-05-12 13:39:13 -07:00 (Migrated from github.com)
Copy Link

@bigfootjon merged this pull request in facebook/yoga@ac7c85c0a6.

@bigfootjon merged this pull request in facebook/yoga@ac7c85c0a629e5029d7e36304d4c02c71da0f41a.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1004
No description provided.
Delete Branch "gh-actions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?