DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

npm run pretest fails #102

New Issue
Closed
opened 2015-08-11 03:45:23 -07:00 by ColinEberhardt · 1 comment
ColinEberhardt commented 2015-08-11 03:45:23 -07:00 (Migrated from github.com)
Copy Link

There are currently a number of eslint issues

$ npm run pretest

> css-layout@0.0.2 pretest /Users/colineberhardt/Projects/css-layout
> ./node_modules/eslint/bin/eslint.js src


src/Layout-test-utils.js
  418:42  error  'navigator' is not defined                no-undef
  453:45  error  expectedLayout is defined but never used  no-unused-vars

src/__tests__/Layout-test.js
  2125:10  error  Trailing comma                           no-comma-dangle
  2140:10  error  Trailing comma                           no-comma-dangle
  2155:10  error  Trailing comma                           no-comma-dangle
  2198:42  error  Trailing comma                           no-comma-dangle
  2206:54  error  Trailing comma                           no-comma-dangle
  2333:18  error  Multiple spaces found before '{'         no-multi-spaces
  2334:18  error  Multiple spaces found before '{'         no-multi-spaces
  2335:18  error  Multiple spaces found before '{'         no-multi-spaces
  2336:18  error  Multiple spaces found before '{'         no-multi-spaces
  2337:18  error  Multiple spaces found before '{'         no-multi-spaces
  2338:18  error  Multiple spaces found before '{'         no-multi-spaces
  2339:18  error  Multiple spaces found before '{'         no-multi-spaces
  2340:18  error  Multiple spaces found before '{'         no-multi-spaces
  2341:18  error  Multiple spaces found before '{'         no-multi-spaces
  2342:18  error  Multiple spaces found before '{'         no-multi-spaces
  2347:62  error  Trailing comma                           no-comma-dangle
  2348:8   error  Trailing comma                           no-comma-dangle
  2350:50  error  Multiple spaces found before 'children'  no-multi-spaces
  2376:20  error  Multiple spaces found before '{'         no-multi-spaces
  2377:20  error  Multiple spaces found before '{'         no-multi-spaces
  2378:20  error  Multiple spaces found before '{'         no-multi-spaces
  2379:20  error  Multiple spaces found before '{'         no-multi-spaces
  2380:20  error  Multiple spaces found before '{'         no-multi-spaces
  2381:20  error  Multiple spaces found before '{'         no-multi-spaces
  2382:20  error  Multiple spaces found before '{'         no-multi-spaces
  2383:20  error  Multiple spaces found before '{'         no-multi-spaces
  2384:20  error  Multiple spaces found before '{'         no-multi-spaces
  2385:20  error  Multiple spaces found before '{'         no-multi-spaces
  2390:64  error  Trailing comma                           no-comma-dangle
  2391:10  error  Trailing comma                           no-comma-dangle

src/transpile.js
   23:37  error    node is defined but never used    no-unused-vars
  277:29  warning  Multiple spaces found before '+'  no-multi-spaces
  278:29  warning  Multiple spaces found before '+'  no-multi-spaces
  279:29  warning  Multiple spaces found before '+'  no-multi-spaces
  280:29  warning  Multiple spaces found before '+'  no-multi-spaces
  282:29  warning  Multiple spaces found before '+'  no-multi-spaces
  283:29  warning  Multiple spaces found before '+'  no-multi-spaces

✖ 39 problems (33 errors, 6 warnings)

And linting / hinting should probably be added to the build. I'll have a look at this alongside #101

There are currently a number of eslint issues ``` $ npm run pretest > css-layout@0.0.2 pretest /Users/colineberhardt/Projects/css-layout > ./node_modules/eslint/bin/eslint.js src src/Layout-test-utils.js 418:42 error 'navigator' is not defined no-undef 453:45 error expectedLayout is defined but never used no-unused-vars src/__tests__/Layout-test.js 2125:10 error Trailing comma no-comma-dangle 2140:10 error Trailing comma no-comma-dangle 2155:10 error Trailing comma no-comma-dangle 2198:42 error Trailing comma no-comma-dangle 2206:54 error Trailing comma no-comma-dangle 2333:18 error Multiple spaces found before '{' no-multi-spaces 2334:18 error Multiple spaces found before '{' no-multi-spaces 2335:18 error Multiple spaces found before '{' no-multi-spaces 2336:18 error Multiple spaces found before '{' no-multi-spaces 2337:18 error Multiple spaces found before '{' no-multi-spaces 2338:18 error Multiple spaces found before '{' no-multi-spaces 2339:18 error Multiple spaces found before '{' no-multi-spaces 2340:18 error Multiple spaces found before '{' no-multi-spaces 2341:18 error Multiple spaces found before '{' no-multi-spaces 2342:18 error Multiple spaces found before '{' no-multi-spaces 2347:62 error Trailing comma no-comma-dangle 2348:8 error Trailing comma no-comma-dangle 2350:50 error Multiple spaces found before 'children' no-multi-spaces 2376:20 error Multiple spaces found before '{' no-multi-spaces 2377:20 error Multiple spaces found before '{' no-multi-spaces 2378:20 error Multiple spaces found before '{' no-multi-spaces 2379:20 error Multiple spaces found before '{' no-multi-spaces 2380:20 error Multiple spaces found before '{' no-multi-spaces 2381:20 error Multiple spaces found before '{' no-multi-spaces 2382:20 error Multiple spaces found before '{' no-multi-spaces 2383:20 error Multiple spaces found before '{' no-multi-spaces 2384:20 error Multiple spaces found before '{' no-multi-spaces 2385:20 error Multiple spaces found before '{' no-multi-spaces 2390:64 error Trailing comma no-comma-dangle 2391:10 error Trailing comma no-comma-dangle src/transpile.js 23:37 error node is defined but never used no-unused-vars 277:29 warning Multiple spaces found before '+' no-multi-spaces 278:29 warning Multiple spaces found before '+' no-multi-spaces 279:29 warning Multiple spaces found before '+' no-multi-spaces 280:29 warning Multiple spaces found before '+' no-multi-spaces 282:29 warning Multiple spaces found before '+' no-multi-spaces 283:29 warning Multiple spaces found before '+' no-multi-spaces ✖ 39 problems (33 errors, 6 warnings) ``` And linting / hinting should probably be added to the build. I'll have a look at this alongside #101
vjeux commented 2015-08-11 09:54:46 -07:00 (Migrated from github.com)
Copy Link

👍

:+1:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#102
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?