DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix percent absolute position and size calcuate different with web #1028

Closed
dislon wants to merge 1 commits from fix_layout_absolute_percentage into main
pull from: fix_layout_absolute_percentage
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 30 +1104 -676
dislon commented 2020-09-01 01:44:12 -07:00 (Migrated from github.com)
Copy Link

This PR fixes issue #850

Additionally,

  • Fix the gentest compatibility with chrome > 75 reference to #1011
  • Regenerated the unit tests by run gentest/gentest.rb
  • Appended ^yoga/tests/*.cpp in .clang-format-ignore.
  • Move the nonautomatic generation tests in YGFlexTest.cpp , YGMinMaxDimensionTest.cpp and YGPercentageTest.cpp to a separate file
  • Fix failed test cases: YogaNodeStylePropertiesTest.java
This PR fixes issue #850 Additionally, - Fix the gentest compatibility with chrome > 75 reference to #1011 - Regenerated the unit tests by run `gentest/gentest.rb` - Appended `^yoga/tests/*.cpp` in `.clang-format-ignore`. - Move the nonautomatic generation tests in `YGFlexTest.cpp `, `YGMinMaxDimensionTest.cpp` and `YGPercentageTest.cpp` to a separate file - Fix failed test cases: `YogaNodeStylePropertiesTest.java `
facebook-github-bot commented 2020-09-01 01:44:23 -07:00 (Migrated from github.com)
Copy Link

Hi @dislon!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Hi @dislon! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%231028). Thanks!
facebook-github-bot commented 2020-09-01 02:05:12 -07:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
dislon commented 2020-09-01 05:45:48 -07:00 (Migrated from github.com)
Copy Link

@SidharthGuglani could you take a look, please? Thank you!

@SidharthGuglani could you take a look, please? Thank you!
NickGerleman commented 2022-12-29 11:56:15 -08:00 (Migrated from github.com)
Copy Link

A lot of the repo has changed since this PR was opened, but I created a new PR #1201 to accept the conformance fix behind a feature flag, so we can test how breaking it is and make default.

A lot of the repo has changed since this PR was opened, but I created a new PR #1201 to accept the conformance fix behind a feature flag, so we can test how breaking it is and make default.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Algorithm
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1028
No description provided.
Delete Branch "fix_layout_absolute_percentage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?