YogaKit wont build on case sensitive systems #1035

New Issue

2020-10-23T07:31:22-07:00

farfromrefug commented

2020-10-23 07:31:22 -07:00

(Migrated from github.com)

Report

[ x] I have searched existing issues and this is not a duplicate

Issues and Steps to Reproduce

Clone on a case sensitive macos system
pod install in the ios tutorial folder.
try to build.

Expected Behavior

build

Actual Behavior

wont build

The reason is that when installing pod headers for Yoga we have mismatching casing:

# Report - [ x] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate # Issues and Steps to Reproduce Clone on a case sensitive macos system `pod install` in the ios tutorial folder. try to build. # Expected Behavior build # Actual Behavior wont build The reason is that when installing pod headers for Yoga we have mismatching casing: <img width="563" alt="Screenshot 2020-10-23 at 16 31 09" src="https://user-images.githubusercontent.com/655344/97016553-29a0c800-154d-11eb-8112-01fd6355a423.png">

👍 5

fondue-tech commented

2022-05-16 01:59:19 -07:00

(Migrated from github.com)

Still issue as of 2022

👍 7

1tac11 commented

2022-05-29 03:05:27 -07:00

(Migrated from github.com)

Still issue here.
Even in plain "react-native init test" project.
That is really bad.

Still issue here. Even in plain "react-native init test" project. That is really bad.

stuckj commented

2022-11-14 14:15:01 -08:00

(Migrated from github.com)

Yep, still broken. You can fix it by manually renaming the directory to Yoga and updating any references in the project. But, it's a pain and really shouldn't be necessary.

Yep, still broken. You can fix it by manually renaming the directory to `Yoga` and updating any references in the project. But, it's a pain and really shouldn't be necessary.

Greenheart commented

2022-12-19 12:21:29 -08:00

(Migrated from github.com)

A workaround is to add the following to the post_install step in ios/Podfile. This way it will be automatically applied when you reinstall dependencies.

# Link headers to fix build on case sensitive file systems
# This will only be executed on case sensitive file systems where "pods" doesn't resolve to "Pods"
unless File.exist? "pods"
  # Ensure Yoga headers end up in the same directory, and create a symlink to allow other iOS code to import fom lowercase "yoga" directory.
  system('cd Pods/Headers/Public; mv `find yoga/*.*` Yoga; rm -rf yoga; ln -sfh Yoga yoga')

  # Add a similar step for each dependency with broken headers
end

A workaround is to add the following to the `post_install` step in `ios/Podfile`. This way it will be automatically applied when you reinstall dependencies. ```rb # Link headers to fix build on case sensitive file systems # This will only be executed on case sensitive file systems where "pods" doesn't resolve to "Pods" unless File.exist? "pods" # Ensure Yoga headers end up in the same directory, and create a symlink to allow other iOS code to import fom lowercase "yoga" directory. system('cd Pods/Headers/Public; mv `find yoga/*.*` Yoga; rm -rf yoga; ln -sfh Yoga yoga') # Add a similar step for each dependency with broken headers end ```

NickGerleman commented

2023-06-13 08:09:34 -07:00

(Migrated from github.com)

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.

👍 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1035