QUESTION: Are the tests in C redundant? #104

New Issue

2015-08-11T08:56:23-07:00

ColinEberhardt commented

2015-08-11 08:56:23 -07:00

(Migrated from github.com)

Just a quick question, the tests in 'C' look like they are all transpiled from the JS tests. Would it be OK if these were removed if the JavaScript tests were run through Travis instead?

I'm just looking to simplify things as much as possible :-)

Just a quick question, the tests in 'C' look like they are all transpiled from the JS tests. Would it be OK if these were removed if the JavaScript tests were run through Travis instead? I'm just looking to simplify things as much as possible :-)

jaredly commented

2015-08-11 08:59:31 -07:00

(Migrated from github.com)

I like the c tests for confidence that the transpilation process was correct
On Tue, Aug 11, 2015 at 8:56 AM Colin Eberhardt notifications@github.com
wrote:

Just a quick question, the tests in 'C' look like they are all transpiled
from the JS tests. Would it be OK if these were removed if the JavaScript
tests were run through Travis instead?

I'm just looking to simplify things as much as possible :-)

—
Reply to this email directly or view it on GitHub
https://github.com/facebook/css-layout/issues/104.

I like the c tests for confidence that the transpilation process was correct On Tue, Aug 11, 2015 at 8:56 AM Colin Eberhardt notifications@github.com wrote: > Just a quick question, the tests in 'C' look like they are all transpiled > from the JS tests. Would it be OK if these were removed if the JavaScript > tests were run through Travis instead? > > I'm just looking to simplify things as much as possible :-) > > — > Reply to this email directly or view it on GitHub > https://github.com/facebook/css-layout/issues/104.

ColinEberhardt commented

2015-08-11 09:01:07 -07:00

(Migrated from github.com)

I like the c tests for confidence that the transpilation process was correct

You trust that transpilation was a success based on tests that run through the same transpiler? Is that wise?!

> I like the c tests for confidence that the transpilation process was correct You trust that transpilation was a success based on tests that run through the same transpiler? Is that wise?!

vjeux commented

2015-08-11 09:10:39 -07:00

(Migrated from github.com)

Yeah, we absolutely need C and Java tests. It ensures that the C and Java code we transpile is not completely bogus. There's non-transpiled code that needs to be "integration" tested. It caught a lot of bugs.

ColinEberhardt commented

2015-08-11 09:19:33 -07:00

(Migrated from github.com)

Thanks @jaredly and @vjeux - if they have a history of catching bugs, they are definitely worth keeping :-)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#104