DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Layout error when sets the width and height of percentage #1058

New Issue
Open
opened 2021-01-14 20:09:57 -08:00 by liuilbury · 0 comments
liuilbury commented 2021-01-14 20:09:57 -08:00 (Migrated from github.com)
Copy Link

Report

Issues and Steps to Reproduce

I use Yoga in this HTML page.

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
</head>
<body style="display: flex;width: 652px;height: 100%;justify-content: center;">
<div style="display: flex;width: 90%;height: 100%;border: 2px solid #990000;flex-direction: row">
    <div style="width: 20%;height:50px;background-color: red;">
    </div>
    <div style="width: 20%;height:50px;background-color: red;">
    </div>
    <div style="width: 20%;height:50px;background-color: red;">
    </div>
    <div style="width: 20%;height:50px;background-color: red;">
    </div>
    <div style="width: 20%;height:50px;background-color: red;">
    </div>
</div>
</body>
</html>

Expected Behavior

The red background fills the entire Div

Actual Behavior

image
Yoga log:

 1.{*wm: LAY_AT_MOST, hm: LAY_AT_MOST, aw: 1904.000000 ah: 990.000000 initial
  2.{*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, aw: 668.000000 ah: 1006.000000 flex_layout
   3.{*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, aw: 586.799988 ah: 990.000000 flex_layout
    4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout
    4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout
    4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout
    4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout
    4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout
    4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout
    4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout
    4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout
    4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout
    4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout
   3.}*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, d: (586.799988, 54.000000) flex_layout
  2.}*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, d: (652.000000, 54.000000) flex_layout
 1.}*wm: LAY_AT_MOST, hm: LAY_AT_MOST, d: (668.000000, 70.000000) initial
<div layout="width: 668; height: 70; top: 0; left: 0;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; max-width: 1904px; max-height: 990px; left: 0px; right: 0px; top: 0px; bottom: 0px; " >
  <div layout="width: 0; height: 0; top: 0; left: 0;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; display: none; left: 0px; right: 0px; top: 0px; bottom: 0px; " >
    <div layout="width: 0; height: 0; top: 0; left: 0;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div>
  </div>
  <div layout="width: 652; height: 54; top: 8; left: 8;" style="flex-direction: row; justify-content: center; align-content: stretch; flex-grow: 0; flex-shrink: 1; margin: 8px; width: 652px; height: 100%; left: 0px; right: 0px; top: 0px; bottom: 0px; " >
    <div layout="width: 586; height: 54; top: 0; left: 33;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; border: 2px; width: 90%; height: 100%; left: 0px; right: 0px; top: 0px; bottom: 0px; " >
      <div layout="width: 116; height: 50; top: 2; left: 2;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div>
      <div layout="width: 117; height: 50; top: 2; left: 119;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div>
      <div layout="width: 116; height: 50; top: 2; left: 235;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div>
      <div layout="width: 117; height: 50; top: 2; left: 352;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div>
      <div layout="width: 116; height: 50; top: 2; left: 468;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div>
    </div>
  </div>
</div>

There is an error in the left calculation here
image

...

When I delete “justify-content: center”, the problem seems to disappear, so the key point is “justify-content: center”??

# Report - [x] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate # Issues and Steps to Reproduce I use Yoga in this HTML page. ```html <!DOCTYPE html> <html> <head> <meta charset="utf-8"> </head> <body style="display: flex;width: 652px;height: 100%;justify-content: center;"> <div style="display: flex;width: 90%;height: 100%;border: 2px solid #990000;flex-direction: row"> <div style="width: 20%;height:50px;background-color: red;"> </div> <div style="width: 20%;height:50px;background-color: red;"> </div> <div style="width: 20%;height:50px;background-color: red;"> </div> <div style="width: 20%;height:50px;background-color: red;"> </div> <div style="width: 20%;height:50px;background-color: red;"> </div> </div> </body> </html> ``` # Expected Behavior The red background fills the entire Div # Actual Behavior ***![image](https://user-images.githubusercontent.com/43340142/104678134-b959ab00-5725-11eb-95ab-c767dc160d77.png)*** Yoga log: ``` 1.{*wm: LAY_AT_MOST, hm: LAY_AT_MOST, aw: 1904.000000 ah: 990.000000 initial 2.{*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, aw: 668.000000 ah: 1006.000000 flex_layout 3.{*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, aw: 586.799988 ah: 990.000000 flex_layout 4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout 4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout 4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout 4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout 4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout 4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout 4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout 4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout 4.{*wm: LAY_EXACTLY, hm: LAY_EXACTLY, aw: 116.559998 ah: 50.000000 flex_layout 4.}*wm: LAY_EXACTLY, hm: LAY_EXACTLY, d: (116.559998, 50.000000) flex_layout 3.}*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, d: (586.799988, 54.000000) flex_layout 2.}*wm: LAY_EXACTLY, hm: LAY_UNDEFINED, d: (652.000000, 54.000000) flex_layout 1.}*wm: LAY_AT_MOST, hm: LAY_AT_MOST, d: (668.000000, 70.000000) initial <div layout="width: 668; height: 70; top: 0; left: 0;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; max-width: 1904px; max-height: 990px; left: 0px; right: 0px; top: 0px; bottom: 0px; " > <div layout="width: 0; height: 0; top: 0; left: 0;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; display: none; left: 0px; right: 0px; top: 0px; bottom: 0px; " > <div layout="width: 0; height: 0; top: 0; left: 0;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div> </div> <div layout="width: 652; height: 54; top: 8; left: 8;" style="flex-direction: row; justify-content: center; align-content: stretch; flex-grow: 0; flex-shrink: 1; margin: 8px; width: 652px; height: 100%; left: 0px; right: 0px; top: 0px; bottom: 0px; " > <div layout="width: 586; height: 54; top: 0; left: 33;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; border: 2px; width: 90%; height: 100%; left: 0px; right: 0px; top: 0px; bottom: 0px; " > <div layout="width: 116; height: 50; top: 2; left: 2;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div> <div layout="width: 117; height: 50; top: 2; left: 119;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div> <div layout="width: 116; height: 50; top: 2; left: 235;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div> <div layout="width: 117; height: 50; top: 2; left: 352;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div> <div layout="width: 116; height: 50; top: 2; left: 468;" style="flex-direction: row; align-content: stretch; flex-grow: 0; flex-shrink: 1; width: 20%; height: 50px; left: 0px; right: 0px; top: 0px; bottom: 0px; " ></div> </div> </div> </div> ``` There is an error in the left calculation here ![image](https://user-images.githubusercontent.com/43340142/104679730-4b16e780-5729-11eb-973d-841c7472a582.png) # ... When I delete “justify-content: center”, the problem seems to disappear, so the key point is “justify-content: center”??
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Algorithm
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1058
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?