DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fixes layout of nodes with YGDisplayNone and YGPositionTypeAbsolute #1068

Closed
rozele wants to merge 1 commits from export-D26849307 into master
pull from: export-D26849307
merge into: DaddyFrosty:master
Conversation 3 Commits 1 Files Changed 8 +201 -21
rozele commented 2021-03-05 10:18:32 -08:00 (Migrated from github.com)
Copy Link

Summary:
There is an issue in react-native when the Yoga node position type is set to absolute and display: none is set where the node layout calculation gives the absolute dimensions, rather than the expected 0 x 0.

Here are some OSS issues tracking this:
https://github.com/facebook/react-native/issues/18415
https://github.com/microsoft/react-native-windows/issues/7289

Differential Revision: D26849307

Summary: There is an issue in react-native when the Yoga node position type is set to absolute and display: none is set where the node layout calculation gives the absolute dimensions, rather than the expected 0 x 0. Here are some OSS issues tracking this: https://github.com/facebook/react-native/issues/18415 https://github.com/microsoft/react-native-windows/issues/7289 Differential Revision: D26849307
❤️ 1
facebook-github-bot commented 2021-03-05 10:18:48 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D26849307

This pull request was **exported** from Phabricator. Differential Revision: [D26849307](https://phabricator.intern.facebook.com/D26849307)
facebook-github-bot commented 2021-03-09 10:08:11 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D26849307

This pull request was **exported** from Phabricator. Differential Revision: [D26849307](https://phabricator.intern.facebook.com/D26849307)
facebook-github-bot commented 2021-03-10 13:10:44 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@342aebe1d7.

This pull request has been merged in facebook/yoga@342aebe1d73e5770a1862b6a94c6b877c1439a9b.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1068
No description provided.
Delete Branch "export-D26849307"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?