DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Added npm deploy when tags are pushed #113

Merged
ColinEberhardt merged 1 commits from ci-releases into master 2015-08-18 11:34:18 -07:00
Conversation 6 Commits 1 Files Changed 1 +10 -1
ColinEberhardt commented 2015-08-17 13:54:55 -07:00 (Migrated from github.com)
Copy Link

With this configuration update a new package will automatically be deployed to npm when the repo is tagged. When this is merged I'd like to propose tagging and releasing v1.0.0

(css-layout is at 0.0.2, the recent changes were breaking, hence 1.0.0 under semver).

@chrisprice can you quickly double check my travis config? it all looks pretty straightforward, but wanted to check based on your prior experience!

closes #101

With this configuration update a new package will automatically be deployed to npm when the repo is tagged. When this is merged I'd like to propose tagging and releasing v1.0.0 (css-layout is at 0.0.2, the recent changes were breaking, hence 1.0.0 under semver). @chrisprice can you quickly double check my travis config? it all looks pretty straightforward, but wanted to check based on your prior experience! closes #101
chrisprice commented 2015-08-18 01:54:00 -07:00 (Migrated from github.com)
Copy Link

LGTM. I remember having problems with the format of the string I encrypted (which made it invalid) but you'll only find that out once you try it :)

LGTM. I remember having problems with the format of the string I encrypted (which made it invalid) but you'll only find that out once you try it :)
vjeux commented 2015-08-18 11:24:26 -07:00 (Migrated from github.com)
Copy Link

So cool :)

So cool :)
ColinEberhardt commented 2015-08-18 11:35:17 -07:00 (Migrated from github.com)
Copy Link

So cool :)

As long as it works! I'm going to try a 0.0.3 release from Travis, then if that works go for 1.0.0 :-)

> So cool :) As long as it works! I'm going to try a 0.0.3 release from Travis, then if that works go for 1.0.0 :-)
ColinEberhardt commented 2015-08-18 11:50:22 -07:00 (Migrated from github.com)
Copy Link

as long as it works!

which it didn't :-(

The Travis build passed, but with the following:

Skipping a deployment with the npm provider because this is not a tagged commit

Although unless I am going crazy, this commit was tagged: 9c31f68f2e

I've double-checked the travis config, but can't see any issues there - @chrisprice any ideas?

> as long as it works! which it didn't :-( The Travis build passed, but with the following: ``` Skipping a deployment with the npm provider because this is not a tagged commit ``` Although unless I am going crazy, this commit was tagged: https://github.com/facebook/css-layout/commit/9c31f68f2e4aff626a4fd858c28d337942053f50 I've double-checked the travis config, but can't see any issues there - @chrisprice any ideas?
chrisprice commented 2015-08-19 01:37:23 -07:00 (Migrated from github.com)
Copy Link

I think that's just a subtlety of how travis-ci works, it creates one build for the tag and one for the master branch commit. As you can see in the logs the first one attempted to deploy but the second one did not.

So why did it fail?

Deploying application
NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc.
http://docs.travis-ci.com/user/deployment/npm/
-npm ERR! publish Failed PUT 401
npm ERR! Linux 3.13.0-40-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.7/bin/node" "/home/travis/.nvm/versions/node/v0.12.7/bin/npm" "publish"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code E401
npm ERR! You must be logged in to publish packages : css-layout
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/facebook/css-layout/npm-debug.log

I'd guess that means the cleartext of the encrypted token is in the wrong format, I can help Colin debug it in person next time I see him (unless he wants to post his password here!).

I think that's just a subtlety of how travis-ci works, it creates [one build for the tag](https://travis-ci.org/facebook/css-layout/builds/76158129) and [one for the `master` branch commit](https://travis-ci.org/facebook/css-layout/builds/76158137). As you can see in the logs the first one attempted to deploy but the second one did not. So why did it fail? ``` Deploying application NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc. http://docs.travis-ci.com/user/deployment/npm/ -npm ERR! publish Failed PUT 401 npm ERR! Linux 3.13.0-40-generic npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.7/bin/node" "/home/travis/.nvm/versions/node/v0.12.7/bin/npm" "publish" npm ERR! node v0.12.7 npm ERR! npm v2.11.3 npm ERR! code E401 npm ERR! You must be logged in to publish packages : css-layout npm ERR! npm ERR! If you need help, you may report this error at: npm ERR! <https://github.com/npm/npm/issues> npm ERR! Please include the following file with any support request: npm ERR! /home/travis/build/facebook/css-layout/npm-debug.log ``` I'd guess that means the cleartext of the encrypted token is in the wrong format, I can help Colin debug it in person next time I see him (unless he wants to post his password here!).
ColinEberhardt commented 2015-08-19 01:47:58 -07:00 (Migrated from github.com)
Copy Link

Thanks Chris, I hadn't spotted that there were two separate builds. Hopefully we
can sort this out later this week.

On Wed, Aug 19, 2015 at 9:37 am, facebook/css-layout
reply@reply.github.com
wrote:
I think that's just a subtlety of how travis-ci works, it creates one build for the tag
[https://travis-ci.org/facebook/css-layout/builds/76158129] and one for the master branch commit
[https://travis-ci.org/facebook/css-layout/builds/76158137] . As you can see in the logs the first one attempted to deploy but the second
one did not.

So why did it fail?

Deploying application
NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc.
http://docs.travis-ci.com/user/deployment/npm/
-npm ERR! publish Failed PUT 401
npm ERR! Linux 3.13.0-40-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.7/bin/node" "/home/travis/.nvm/versions/node/v0.12.7/bin/npm" "publish"
npm ERR! node v0.12.7
npm ERR! npm v2.11.3
npm ERR! code E401
npm ERR! You must be logged in to publish packages : css-layout
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR! https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR! /home/travis/build/facebook/css-layout/npm-debug.log

I'd guess that means the cleartext of the encrypted token is in the wrong
format, I can help Colin debug it in person next time I see him (unless he wants
to post his password here!).

—
Reply to this email directly or view it on GitHub
[https://github.com/facebook/css-layout/pull/113#issuecomment-132493911] .[https://github.com/notifications/beacon/ABDBfltaf01XDXDtOrO7N9o3DZVjspdxks5opDfGgaJpZM4FtHAN.gif]

Thanks Chris, I hadn't spotted that there were two separate builds. Hopefully we can sort this out later this week. On Wed, Aug 19, 2015 at 9:37 am, facebook/css-layout reply@reply.github.com wrote: I think that's just a subtlety of how travis-ci works, it creates one build for the tag [https://travis-ci.org/facebook/css-layout/builds/76158129] and one for the master branch commit [https://travis-ci.org/facebook/css-layout/builds/76158137] . As you can see in the logs the first one attempted to deploy but the second one did not. So why did it fail? Deploying application NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc. http://docs.travis-ci.com/user/deployment/npm/ -npm ERR! publish Failed PUT 401 npm ERR! Linux 3.13.0-40-generic npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.7/bin/node" "/home/travis/.nvm/versions/node/v0.12.7/bin/npm" "publish" npm ERR! node v0.12.7 npm ERR! npm v2.11.3 npm ERR! code E401 npm ERR! You must be logged in to publish packages : css-layout npm ERR! npm ERR! If you need help, you may report this error at: npm ERR! https://github.com/npm/npm/issues npm ERR! Please include the following file with any support request: npm ERR! /home/travis/build/facebook/css-layout/npm-debug.log I'd guess that means the cleartext of the encrypted token is in the wrong format, I can help Colin debug it in person next time I see him (unless he wants to post his password here!). — Reply to this email directly or view it on GitHub [https://github.com/facebook/css-layout/pull/113#issuecomment-132493911] .[https://github.com/notifications/beacon/ABDBfltaf01XDXDtOrO7N9o3DZVjspdxks5opDfGgaJpZM4FtHAN.gif]
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#113
No description provided.
Delete Branch "ci-releases"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?