Start Adding GitHub Actions #1165

2022-10-06T06:01:26-07:00

NickGerleman commented

2022-10-06 06:01:26 -07:00

(Migrated from github.com)

This change starts adding more coverage to GitHub Actions. Existing workflows are split up to be per-platform, and stale scripts, etc are removed.

We are currently limited a bit by issues with the build itself, but this still adds a good bit of coverage that readily works, and adds places to inject more.

Another option would have been to move these to CircleCI where we have more credits, or used docker images instead of manual setup steps. etc, The Yoga build and number of changes is very light though, so we don't really need the complexity yet.

Some TODOs:

Fix the Apple Builds (pod lint and pod install return errors seen by the community)
Add working Android UTs
Add C++ UTs
Add Apple Publish
Add version stamping

This change starts adding more coverage to GitHub Actions. Existing workflows are split up to be per-platform, and stale scripts, etc are removed. We are currently limited a bit by issues with the build itself, but this still adds a good bit of coverage that readily works, and adds places to inject more. Another option would have been to move these to CircleCI where we have more credits, or used docker images instead of manual setup steps. etc, The Yoga build and number of changes is very light though, so we don't really need the complexity yet. Some TODOs: 1. Fix the Apple Builds (pod lint and pod install return errors seen by the community) 2. Add working Android UTs 3. Add C++ UTs 4. Add Apple Publish 5. Add version stamping

facebook-github-bot commented

2022-10-14 09:25:08 -07:00

(Migrated from github.com)

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D40386426).

facebook-github-bot commented

2022-10-14 09:54:36 -07:00

(Migrated from github.com)

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D40386426).

NickGerleman (Migrated from github.com) reviewed 2022-10-14 14:20:58 -07:00

.github/actions/clang-format/action.yml

						
				@@ -0,0 +1,24 @@

				name: Clang Format

NickGerleman (Migrated from github.com) commented

2022-10-14 14:20:58 -07:00

      run: sudo apt-get install -y clang-format-${{ inputs.version }}

```suggestion run: sudo apt-get install -y clang-format-${{ inputs.version }} ```

NickGerleman (Migrated from github.com) reviewed 2022-10-14 14:22:52 -07:00

.github/workflows/valiadate-android.yml

NickGerleman (Migrated from github.com) commented

2022-10-14 14:22:52 -07:00

        run: npx --yes google-java-format --set-exit-if-changed --dry-run --glob=java/**/*.java

```suggestion run: npx --yes google-java-format --set-exit-if-changed --dry-run --glob=java/**/*.java ```

facebook-github-bot commented

2022-10-17 15:03:24 -07:00

(Migrated from github.com)

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D40386426).

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1165

				`@@ -0,0 +1,24 @@`
				`name: Clang Format`