DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix memory leak #1167

Closed
simonla wants to merge 1 commits from main into main
pull from: main
merge into: DaddyFrosty:main
Conversation 2 Commits 1 Files Changed 1 +102988 -208720
simonla commented 2022-10-12 04:50:40 -07:00 (Migrated from github.com)
Copy Link
image

root_child0 be removed byYGNodeRemoveChild(root, root_child0);
so YGNodeFreeRecursive(root); can not free root_child0

<img width="1126" alt="image" src="https://user-images.githubusercontent.com/14934570/195335369-e3fccde7-ff6c-4437-a261-7bc7435143c2.png"> `root_child0` be removed by`YGNodeRemoveChild(root, root_child0);` so `YGNodeFreeRecursive(root);` can not free `root_child0`
motiz88 commented 2022-10-12 05:06:04 -07:00 (Migrated from github.com)
Copy Link

Looks good, thanks @simonla!

Looks good, thanks @simonla!
facebook-github-bot commented 2022-10-12 05:06:28 -07:00 (Migrated from github.com)
Copy Link

@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D40298891).

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1167
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?