DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

definition of implicit copy constructor for 'Values<9>' is deprecated because it has a user-declared copy assignment operator #1174

New Issue
Closed
opened 2022-11-17 02:38:37 -08:00 by summerHearts · 2 comments
summerHearts commented 2022-11-17 02:38:37 -08:00 (Migrated from github.com)
Copy Link

Report

Issues and Steps to Reproduce

Xcode14.1
image

In file included from Carthage/Checkouts/yoga/yoga/Utils.h:9:
In file included from Carthage/Checkouts/yoga/yoga/YGNode.h:13:
In file included from Carthage/Checkouts/yoga/yoga/YGConfig.h:9:
Carthage/Checkouts/yoga/yoga/Yoga-internal.h:135:11: error: definition of implicit copy constructor for 'Values<9>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
Values& operator=(const Values& ot

Expected Behavior

build success

Actual Behavior

run WildeGuess

# Report - [x] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate # Issues and Steps to Reproduce Xcode14.1 <img width="1366" alt="image" src="https://user-images.githubusercontent.com/10678821/202424600-b1be4ebd-f827-4f6b-8fda-13060f6e0823.png"> In file included from Carthage/Checkouts/yoga/yoga/Utils.h:9: In file included from Carthage/Checkouts/yoga/yoga/YGNode.h:13: In file included from Carthage/Checkouts/yoga/yoga/YGConfig.h:9: Carthage/Checkouts/yoga/yoga/Yoga-internal.h:135:11: error: definition of implicit copy constructor for 'Values<9>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy] Values& operator=(const Values& ot # Expected Behavior build success # Actual Behavior run WildeGuess
NickGerleman commented 2022-11-21 12:31:18 -08:00 (Migrated from github.com)
Copy Link

It seems like the explicit copy ctor isn't needed here since all it is doing is copying the underlying array anyway. Misread this I think we just need to add a default copy ctor.

~It seems like the explicit copy ctor isn't needed here since all it is doing is copying the underlying array anyway.~ Misread this I think we just need to add a default copy ctor.
0xnalou commented 2024-02-21 00:28:46 -08:00 (Migrated from github.com)
Copy Link

is it fixed ?
I stil get error when build from tutorial: https://componentkit.org/docs/getting-started/

is it fixed ? I stil get error when build from tutorial: https://componentkit.org/docs/getting-started/
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Build and Infrastructure
YogaKit
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1174
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?