DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add newer fixtures #1194

Open
NickGerleman wants to merge 1 commits from NickGerleman/export-D42242096 into main
pull from: NickGerleman/export-D42242096
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 60 +6614 -1204
NickGerleman commented 2022-12-26 16:43:56 -08:00 (Migrated from github.com)
Copy Link

Summary:
flexlayout has the same fixtures forked from Yoga, with some disabled, and some added. This syncs that list to Yoga, adding the fixes made to it along with new fixtures.

One new test absolute_child_with_max_height_larger_shrinkable_grandchild is failing, along with two fixtures where Chrome had recently changed its behaviors. These are commented out at the moment before I do something smarter with the test runner to allow more fixtures.

Differential Revision: D42242096

Summary: flexlayout has the same fixtures forked from Yoga, with some disabled, and some added. This syncs that list to Yoga, adding the fixes made to it along with new fixtures. One new test absolute_child_with_max_height_larger_shrinkable_grandchild is failing, along with two fixtures where Chrome had recently changed its behaviors. These are commented out at the moment before I do something smarter with the test runner to allow more fixtures. Differential Revision: D42242096
facebook-github-bot commented 2022-12-26 16:44:32 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D42242096

This pull request was **exported** from Phabricator. Differential Revision: [D42242096](https://www.internalfb.com/diff/D42242096)
nicoburns commented 2023-01-18 03:59:45 -08:00 (Migrated from github.com)
Copy Link

@NickGerleman Not the biggest issue, but the test justify_content_colunn_max_height_and_margin has a typo (should be column not colunn) reported to Taffy here https://github.com/DioxusLabs/taffy/pull/330. The issue wasn't introduced by this PR, but maybe it would be a good place to fix it?

@NickGerleman Not the biggest issue, but the test `justify_content_colunn_max_height_and_margin` has a typo (should be `column` not `colunn`) reported to Taffy here https://github.com/DioxusLabs/taffy/pull/330. The issue wasn't introduced by this PR, but maybe it would be a good place to fix it?
nicoburns commented 2023-05-06 09:58:34 -07:00 (Migrated from github.com)
Copy Link

Looks like gtest allows you to disable tests by prefixing the test name with DISABLED_. Seems like it could be a good way to go for known failures? https://stackoverflow.com/questions/7208070/googletest-how-to-skip-a-test

Looks like gtest allows you to disable tests by prefixing the test name with `DISABLED_`. Seems like it could be a good way to go for known failures? https://stackoverflow.com/questions/7208070/googletest-how-to-skip-a-test
NickGerleman commented 2023-05-08 12:12:28 -07:00 (Migrated from github.com)
Copy Link

Looks like gtest allows you to disable tests by prefixing the test name with DISABLED_. Seems like it could be a good way to go for known failures? https://stackoverflow.com/questions/7208070/googletest-how-to-skip-a-test

Teaching the test generator to emit annotations to skip tests would be a good concrete step towards getting some of this cleaned up. Patterned after what was done for experimental features, we could maybe add an HTML attribute like skip-test="true" or data-skip-test="true".

Then we would emit for GTest, add test.skip for Jest, etc, for the different test backeends.

> Looks like gtest allows you to disable tests by prefixing the test name with `DISABLED_`. Seems like it could be a good way to go for known failures? https://stackoverflow.com/questions/7208070/googletest-how-to-skip-a-test Teaching the test generator to emit annotations to skip tests would be a good concrete step towards getting some of this cleaned up. Patterned after what was done for experimental features, we could maybe add an HTML attribute like `skip-test="true"` or `data-skip-test="true"`. Then we would emit for GTest, add `test.skip` for Jest, etc, for the different test backeends.
This pull request has changes conflicting with the target branch.
  • csharp/tests/Facebook.Yoga/YGAbsolutePositionTest.cs
  • csharp/tests/Facebook.Yoga/YGAlignContentTest.cs
  • csharp/tests/Facebook.Yoga/YGAlignItemsTest.cs
  • csharp/tests/Facebook.Yoga/YGAlignSelfTest.cs
  • csharp/tests/Facebook.Yoga/YGBorderTest.cs
  • csharp/tests/Facebook.Yoga/YGDisplayTest.cs
  • csharp/tests/Facebook.Yoga/YGFlexDirectionTest.cs
  • csharp/tests/Facebook.Yoga/YGFlexTest.cs
  • csharp/tests/Facebook.Yoga/YGMarginTest.cs
  • csharp/tests/Facebook.Yoga/YGMinMaxDimensionTest.cs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin NickGerleman/export-D42242096:NickGerleman/export-D42242096
git checkout NickGerleman/export-D42242096
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1194
No description provided.
Delete Branch "NickGerleman/export-D42242096"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?