DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Use more specific enums types where previously using number #1198

Closed
NickGerleman wants to merge 1 commits from export-D42265824 into main
pull from: export-D42265824
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 1 +13 -11
NickGerleman commented 2022-12-28 02:24:10 -08:00 (Migrated from github.com)
Copy Link

Summary: The Yoga JS bindings converted a previous Flow type directly to TypeScript. The enum types we expose are safer than accepting raw ordinal numbers, and we should replace the places in the typings where an ordinal was accepted instead of the specific type.

Differential Revision: D42265824

Summary: The Yoga JS bindings converted a previous Flow type directly to TypeScript. The enum types we expose are safer than accepting raw ordinal numbers, and we should replace the places in the typings where an ordinal was accepted instead of the specific type. Differential Revision: D42265824
facebook-github-bot commented 2022-12-28 02:24:38 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D42265824

This pull request was **exported** from Phabricator. Differential Revision: [D42265824](https://www.internalfb.com/diff/D42265824)
facebook-github-bot commented 2022-12-29 09:07:27 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D42265824

This pull request was **exported** from Phabricator. Differential Revision: [D42265824](https://www.internalfb.com/diff/D42265824)
facebook-github-bot commented 2022-12-29 09:12:34 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D42265824

This pull request was **exported** from Phabricator. Differential Revision: [D42265824](https://www.internalfb.com/diff/D42265824)
facebook-github-bot commented 2022-12-30 14:22:54 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@9fe1e77274.

This pull request has been merged in facebook/yoga@9fe1e772749d1320cc1a0d9cc06334e502faa1f6.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1198
No description provided.
Delete Branch "export-D42265824"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?